Adds some rules to exclude invalid images#347
Open
Pacodastre wants to merge 1 commit intoDrop-OSS:developfrom
Open
Adds some rules to exclude invalid images#347Pacodastre wants to merge 1 commit intoDrop-OSS:developfrom
Pacodastre wants to merge 1 commit intoDrop-OSS:developfrom
Conversation
Pacodastre
force-pushed
the
only-accept-valid-images-for-upload
branch
from
e12a96f to
3eaaf1c
Compare
DecDuck
requested changes
Feb 9, 2026
Member
DecDuck
left a comment
DecDuck
left a comment
There was a problem hiding this comment.
statusMessage -> message is fine.
Just a comment about refactoring the MIME type check.
| throw createError({ statusCode: 400, statusMessage: "Invalid company id" }); | ||
| throw createError({ statusCode: 400, message: "Invalid company id" }); | ||
|
|
||
| const formData = await readMultipartFormData(h3); |
Member
There was a problem hiding this comment.
Maybe build this functionality into the handleFileUpload util? Like an optional argument that defines valid MIME types or MIME type prefixes
Huskydog9988
suggested changes
Feb 9, 2026
Comment on lines
+3
to
+10
| export const IMAGE_EXTENSIONS = [ | ||
| "bmp", | ||
| "gif", | ||
| "ico", | ||
| "jpeg", | ||
| "heic", | ||
| "png", | ||
| "tiff", |
Contributor
There was a problem hiding this comment.
I don't think we absolutely need to cover every possible item, but support for svg, webp, avif, and maybe even jxl are a must imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed some
statusMessagetomessagein the files I touched. Let me know if I shouldn't have done that.It shows an error message when a file is not a valid image
I fixed a minor bug in the game logo upload. If an invalid image was selected, then saved. Upon reopening the modal to upload the logo, the image used to appear broken as it was trying to render the previous invalid image. This is fixed by not updating the logo if it's not valid.