Skip to content

Skip invalid daw projects during the scan #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DropSnorz merged 1 commit into from
May 19, 2026
Merged

Skip invalid daw projects during the scan #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 28 additions & 25 deletions owlplug-client/src/main/java/com/owlplug/project/tasks/ProjectSyncTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
import com.owlplug.core.utils.FileUtils;
import com.owlplug.project.model.DawProject;
import com.owlplug.project.repositories.DawProjectRepository;
import com.owlplug.project.tasks.discovery.ProjectExplorer;
import com.owlplug.project.tasks.discovery.ProjectExplorerException;
import com.owlplug.project.tasks.discovery.ableton.AbletonProjectExplorer;
import com.owlplug.project.tasks.discovery.reaper.ReaperProjectExplorer;
import com.owlplug.project.tasks.discovery.studioone.StudioOneProjectExplorer;
Expand All @@ -36,8 +38,9 @@ public class ProjectSyncTask extends AbstractTask {

private final Logger log = LoggerFactory.getLogger(this.getClass());

private DawProjectRepository projectRepository;
private List<String> projectDirectories;
private boolean hasParseErrors = false;
private final DawProjectRepository projectRepository;
private final List<String> projectDirectories;

public ProjectSyncTask(DawProjectRepository projectRepository,
List<String> projectDirectories) {
Expand Down Expand Up @@ -73,36 +76,36 @@ protected TaskResult start() throws Exception {

this.setMaxProgress(filteredFiles.size());

// Create explorer instances once, outside the loop (they are stateless)
AbletonProjectExplorer abletonExplorer = new AbletonProjectExplorer();
ReaperProjectExplorer reaperExplorer = new ReaperProjectExplorer();
StudioOneProjectExplorer studioOneExplorer = new StudioOneProjectExplorer();
List<ProjectExplorer> explorers = List.of(
new AbletonProjectExplorer(),
new ReaperProjectExplorer(),
new StudioOneProjectExplorer()
);

for (File file : filteredFiles) {
this.commitProgress(1);

if (abletonExplorer.canExploreFile(file)) {
this.updateMessage("Analyzing Ableton file: " + file.getAbsolutePath());
DawProject project = abletonExplorer.explore(file);
if (project != null) {
projectRepository.save(project);
}
} else if (reaperExplorer.canExploreFile(file)) {
this.updateMessage("Analyzing Reaper file: " + file.getAbsolutePath());
DawProject project = reaperExplorer.explore(file);
if (project != null) {
projectRepository.save(project);
}
} else if (studioOneExplorer.canExploreFile(file)) {
this.updateMessage("Analyzing Studio One file: " + file.getAbsolutePath());
DawProject project = studioOneExplorer.explore(file);
if (project != null) {
projectRepository.save(project);
for (ProjectExplorer explorer : explorers) {
if (explorer.canExploreFile(file)) {
try {
this.updateMessage("Analyzing project file: " + file.getAbsolutePath());
DawProject project = explorer.explore(file);
if (project != null) {
projectRepository.save(project);
}
} catch (ProjectExplorerException e) {
hasParseErrors = true;
log.error("Failed to parse project file, skipping: {}", file.getAbsolutePath(), e);
}
break;
}
}
}

this.updateMessage("All projects are synchronized");
if (hasParseErrors) {
this.updateMessage("Projects synchronized. Some files cannot be parsed, check application logs in Options.");
} else {
this.updateMessage("All projects are synchronized");
}
this.updateProgress(1,1);

return completed();
Expand Down