fix: update vulnerable Hickory DNS dependencies#786
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Rust dependencies to remediate the Hickory DNS advisory (GHSA-3v94-mw7p-v465) by consolidating Hickory crates on 0.26.1, bumping reqwest to 0.13.4, and upgrading dcap-qvl to 0.5.2, with corresponding API adaptations across the codebase.
Changes:
- Upgrade
reqwestto0.13.4and adjust TLS/root-certs configuration code for the new API. - Consolidate
hickory-resolverusage on0.26.1and update resolver call sites to new types/APIs. - Upgrade
dcap-qvlto0.5.2and migrate collateral fetching/verification toCollateralClient.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| dstack/tdx-attest/examples/test_tdx.rs | Switches quote verification to dcap-qvl CollateralClient API. |
| dstack/ra-rpc/src/client.rs | Updates reqwest TLS/root-cert configuration to reqwest 0.13 APIs. |
| dstack/ra-rpc/Cargo.toml | Updates reqwest feature flags for the new reqwest version. |
| dstack/nsm-qvl/Cargo.toml | Updates reqwest feature flags for the new reqwest version. |
| dstack/gateway/src/proxy/tls_passthough.rs | Migrates DNS TXT resolution to Hickory 0.26.1 resolver/lookup APIs and preserves caching behavior. |
| dstack/dstack-util/src/host_api.rs | Migrates quote collateral fetch/verify to CollateralClient and normalizes PCCS URL handling. |
| dstack/dstack-attest/src/attestation.rs | Centralizes PCCS/collateral client creation and migrates TDX verification calls to CollateralClient. |
| dstack/ct_monitor/Cargo.toml | Updates reqwest feature flags for the new reqwest version. |
| dstack/certbot/src/acme_client.rs | Migrates ACME DNS TXT self-check to Hickory 0.26.1 resolver/lookup APIs. |
| dstack/Cargo.toml | Bumps workspace versions for reqwest, dcap-qvl, and hickory-resolver (and reqwest feature set). |
| dstack/Cargo.lock | Removes vulnerable Hickory versions and locks updated dependency graph (including new transitive crates). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dcap-qvlto the released0.5.2andreqwestto0.13.4hickory-dnsresolver and consolidate Hickory on0.26.1hickory-proto 0.25.2fromCargo.lockThis addresses Dependabot alert #357 (
GHSA-3v94-mw7p-v465).Validation
cargo fmt --check --allcargo clippy -- -D warnings -D clippy::expect_used -D clippy::unwrap_used --allow unused_variablescargo check --workspace --all-targets./run-tests.shhickory-net,hickory-proto, andhickory-resolver0.26.1