Add BufferedLogSink drop visibility (counter + error handler)#15
Merged
Add BufferedLogSink drop visibility (counter + error handler)#15
Conversation
Surface silent message drops when the bounded channel is full by adding an atomic DroppedCount property and throttled InternalErrorHandler notifications via a new LogDroppedException type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DroppedCountproperty toBufferedLogSinkfor monitoring dropped messagesInternalErrorHandlerwith per-second throttling viaLogDroppedExceptionerrorHandlerthroughFileSink,StreamSink, andLogConfigBuilderhelper methodsReason for Change
When
BufferedLogSink's bounded channel is full,TryWrite()fails and messages are silently dropped. Applications have no way to detect log data loss under back-pressure.Impact
BufferedLogSinknow exposes aDroppedCountproperty queryable for health checks and metricsInternalErrorHandleris configured, it receivesLogDroppedExceptionon the first drop and then at most once per secondMigration Steps
No migration required. The new
errorHandlerparameter onBufferedLogSink,FileSink, andStreamSinkconstructors is optional with a default ofnull. Existing code compiles and behaves identically.Performance Considerations
Interlocked.Incrementand oneVolatile.Read— negligible overheadSecurity Considerations
None.
Breaking Changes