Fix non-deterministic caller resolution in call graph tracking#16
Draft
Copilot wants to merge 3 commits into
Draft
Fix non-deterministic caller resolution in call graph tracking#16Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Co-authored-by: DubiousCactus <7703484+DubiousCactus@users.noreply.github.com>
Co-authored-by: DubiousCactus <7703484+DubiousCactus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate issue number 15
Fix non-deterministic caller resolution in call graph tracking
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On second rerun,
get_rays()fails with assertion error despite identical inputs. Root cause: callerparams_hashresolution iterates all graph nodes without breaking, using last match. When multiple nodes exist for the same function (after 2nd+ reruns), selection becomes non-deterministic.Changes
Added execution stack to track active call chain in
CallTrackerModified caller resolution to check stack first (top = current caller), fallback to graph search with break
Fixed caching logic to allow None return values (removed incorrect
result is not Nonecheck)Before/After
The stack ensures correct caller identification when multiple nodes with same function exist in the graph.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.