Add per-move PA field and capability bit for CAN motion compatibility for adaptive pressure advance#9
Open
Argolein wants to merge 2 commits intoDuet3D:3.6-devfrom
Open
Add per-move PA field and capability bit for CAN motion compatibility for adaptive pressure advance#9Argolein wants to merge 2 commits intoDuet3D:3.6-devfrom
Argolein wants to merge 2 commits intoDuet3D:3.6-devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends CAN message formats to support per-move Pressure Advance snapshots and explicit capability signaling.
What changed
pressureAdvanceClockstoCanMessageMovementLinearShaped.supportsMovementPaSnapshotcapability bit to announce message format.Why
Adaptive PA requires carrying the PA value with each queued move across CAN boundaries. Capability signaling is needed to detect incompatible firmware combinations safely.
Result
CAN protocol now supports per-move PA transport and compatibility negotiation for this feature.