Closed
Conversation
Fixes the issue for: ``` unknown encoding: BASE64 ```
where we initially check whether part is the attachments. Rather doing that in the last step, otherwise attachments with mimetype of text/html would not be extracted out of the eml file
…erge of arkagpl:master DusanKasan#28 and matoubidou:master DusanKasan#26)
k3a
force-pushed
the
master
branch
5 times, most recently
from
f7e3687 to
15c86d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I integrated all open PRs into my fork:
Some of them required manual merging but the resulting code should be correct, hopefully.
I am providing this as a PR to the original repo first.
The library is quite nice but the original repo seems to be unmaintained for more than 3 years and the library is largely broken without those PRs.
If there is no response by the original author in a week, I will attempt to make my repo to be some kind of 'official fork', set up CI for it and handle any future PRs.