Skip to content

fix sustain note end_time didn't apply music_start_offset #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hiki8man wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix sustain note end_time didn't apply music_start_offset #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fff5d3b
Fix sustain length calculation in DSCConverter
hiki8man Jun 30, 2026
6041f06
sustain end time should also use music_start_offset
hiki8man Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion autoloads/song_loader/song_loaders/DSCConverter.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ static func convert_dsc_opcodes_to_chart(r: Array, opcode_map: DSCOpcodeMap, off

# Set sustain length
if opcode.params[1] != -1:
(note_d as HBSustainNote).end_time = time + flying_time + (opcode.params[1] / 100.0) + offset
(note_d as HBSustainNote).end_time = time + flying_time + (opcode.params[1] / 100.0)
found_sustain_length = true

elif is_nc_rush(opcode.params[0]):
Expand Down Expand Up @@ -591,5 +591,7 @@ static func convert_dsc_opcodes_to_chart(r: Array, opcode_map: DSCOpcodeMap, off
for layer in chart.layers:
for timing_point in layer.timing_points:
timing_point.time -= music_start_offset
if timing_point is HBSustainNote:
timing_point.end_time -= music_start_offset

return [chart, timing_changes]