Skip to content

Update routes.py #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ELI-student001 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update routes.py #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

if name:
cursor.execute(
"SELECT * FROM books WHERE name LIKE %s", name
"SELECT * FROM books WHERE name LIKE '%" + name + "%'"

Check failure

Code scanning / CodeQL

SQL query built from user-controlled sources High

This SQL query depends on a
user-provided value
Loading
.

Copilot Autofix

AI 8 months ago

To fix this vulnerability in server/routes.py, replace the unsafe string concatenation in the SQL query on line 16 with a parameterized query using the DB API provided by the cursor object. Most Python DB connectors (including those underlying Flask and SQLAlchemy) support using placeholders (often %s for positional parameters) in SQL, with actual parameter values passed as separate arguments. For SQL LIKE statements, you usually need to format the % wildcards as part of the parameter—not inside the query string—so use "SELECT * FROM books WHERE name LIKE %s" with the parameter being f"%{name}%". No new imports are needed. Only line 16 (and the lines around it for context) need to be updated.

Suggested changeset 1
server/routes.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/server/routes.py b/server/routes.py
--- a/server/routes.py
+++ b/server/routes.py
@@ -13,7 +13,7 @@
 
     if name:
         cursor.execute(
-            "SELECT * FROM books WHERE name LIKE '%" + name + "%'"
+            "SELECT * FROM books WHERE name LIKE %s", (f"%{name}%",)
         )
         books = [Book(*row) for row in cursor]
 
EOF
@@ -13,7 +13,7 @@

if name:
cursor.execute(
"SELECT * FROM books WHERE name LIKE '%" + name + "%'"
"SELECT * FROM books WHERE name LIKE %s", (f"%{name}%",)
)
books = [Book(*row) for row in cursor]

Copilot is powered by AI and may make mistakes. Always verify output.
)
books = [Book(*row) for row in cursor]

Expand Down