Skip to content

Remove some boost#219

Open
mesokurtic wants to merge 6 commits into
EMOD-Hub:mainfrom
mesokurtic:boost_v01
Open

Remove some boost#219
mesokurtic wants to merge 6 commits into
EMOD-Hub:mainfrom
mesokurtic:boost_v01

Conversation

@mesokurtic

Copy link
Copy Markdown

Reorganizes the BoostLibWrapper file to show the 3 major remaining boost dependencies. Removes all others:

  1. Bimap
  2. UUIDs
  3. Preprocessor

Also adds the current working directory to the end of the list of directories to check for input files. Seemed kind of strange not to check the working directory by default 😉

@kfrey-idm

Copy link
Copy Markdown
Member

Oh, wow! Thank you @mesokurtic for your community contribution!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces Boost usage by simplifying the central Boost include wrapper and removing now-unneeded Boost-related scaffolding, while also adjusting file search behavior to include the current working directory.

Changes:

  • Removed Profile.h and the USE_BOOST_* macro-gating pattern; trimmed BoostLibWrapper.h to the remaining Boost dependencies (bimap/uuid/preprocessor).
  • Replaced boost::lexical_cast usage with std::to_string and simplified FileNotFoundException down to a single constructor, updating call sites accordingly.
  • Updated input file searching to always include the current working directory in Environment::Initialize.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
utils/utils.vcxproj.filters Removes deleted Profile.h from VS project filters.
utils/utils.vcxproj Removes deleted Profile.h from VS project includes.
utils/suids.hpp Removes Boost-UUID-referential comments and simplifies generator comment.
utils/ProgramOptions.h Removes Boost program_options referential comment.
utils/Profile.h Deletes Boost feature-flag header (USE_BOOST_*).
utils/FileSystem.cpp Simplifies FileExists implementation and updates FileNotFoundException call.
utils/Exceptions.h Removes Boost lexical_cast include and collapses FileNotFoundException API to one ctor.
utils/Exceptions.cpp Replaces lexical_cast with std::to_string, simplifies exception plumbing, updates FileNotFoundException message.
utils/Environment.cpp Adds “.” to input search paths (currently appended last) and updates FileNotFoundException call sites.
utils/EnumSupport.h Switches Boost.Preprocessor include to go through BoostLibWrapper.h.
utils/ConfigurationImpl.h Removes unused Boost type_traits include and deletes large dead/commented blocks.
utils/BoostLibWrapper.h Reorganizes wrapper to only include remaining Boost dependencies.
Eradication/Simulation.cpp Updates FileNotFoundException call sites to new signature.
Eradication/NodeInfoVector.cpp Removes Profile.h include.
Eradication/NodeInfo.cpp Removes Profile.h include.
Eradication/Climate.h Minor pointer formatting and trailing whitespace cleanup.
Eradication/Climate.cpp Removes dead/commented blocks and minor formatting tweaks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread utils/Exceptions.cpp
Comment thread utils/EnumSupport.h
Comment thread utils/Environment.cpp
@kfrey-idm

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants