Remove some boost#219
Open
mesokurtic wants to merge 6 commits into
Open
Conversation
Member
|
Oh, wow! Thank you @mesokurtic for your community contribution! |
There was a problem hiding this comment.
Pull request overview
This PR reduces Boost usage by simplifying the central Boost include wrapper and removing now-unneeded Boost-related scaffolding, while also adjusting file search behavior to include the current working directory.
Changes:
- Removed
Profile.hand theUSE_BOOST_*macro-gating pattern; trimmedBoostLibWrapper.hto the remaining Boost dependencies (bimap/uuid/preprocessor). - Replaced
boost::lexical_castusage withstd::to_stringand simplifiedFileNotFoundExceptiondown to a single constructor, updating call sites accordingly. - Updated input file searching to always include the current working directory in
Environment::Initialize.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/utils.vcxproj.filters | Removes deleted Profile.h from VS project filters. |
| utils/utils.vcxproj | Removes deleted Profile.h from VS project includes. |
| utils/suids.hpp | Removes Boost-UUID-referential comments and simplifies generator comment. |
| utils/ProgramOptions.h | Removes Boost program_options referential comment. |
| utils/Profile.h | Deletes Boost feature-flag header (USE_BOOST_*). |
| utils/FileSystem.cpp | Simplifies FileExists implementation and updates FileNotFoundException call. |
| utils/Exceptions.h | Removes Boost lexical_cast include and collapses FileNotFoundException API to one ctor. |
| utils/Exceptions.cpp | Replaces lexical_cast with std::to_string, simplifies exception plumbing, updates FileNotFoundException message. |
| utils/Environment.cpp | Adds “.” to input search paths (currently appended last) and updates FileNotFoundException call sites. |
| utils/EnumSupport.h | Switches Boost.Preprocessor include to go through BoostLibWrapper.h. |
| utils/ConfigurationImpl.h | Removes unused Boost type_traits include and deletes large dead/commented blocks. |
| utils/BoostLibWrapper.h | Reorganizes wrapper to only include remaining Boost dependencies. |
| Eradication/Simulation.cpp | Updates FileNotFoundException call sites to new signature. |
| Eradication/NodeInfoVector.cpp | Removes Profile.h include. |
| Eradication/NodeInfo.cpp | Removes Profile.h include. |
| Eradication/Climate.h | Minor pointer formatting and trailing whitespace cleanup. |
| Eradication/Climate.cpp | Removes dead/commented blocks and minor formatting tweaks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Looks pretty good! https://github.com/EMOD-Hub/EMOD/actions/runs/27504727496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganizes the BoostLibWrapper file to show the 3 major remaining boost dependencies. Removes all others:
Also adds the current working directory to the end of the list of directories to check for input files. Seemed kind of strange not to check the working directory by default 😉