Analog module update#10
Merged
Merged
Conversation
… rather than index.
…nal arrays now allocate on heap.
…gers. Added channel retarget. Abstracted device specifics.
… accepts pointer to qubits (as qreg).
…eters are based on the device now.
otbrown
approved these changes
Oct 23, 2025
otbrown
left a comment
otbrown
left a comment
Collaborator
There was a problem hiding this comment.
Hi Mateusz, I think this is fine, but could you check my find/replace on GLOBAL and LOCAL hasn't beeen overly aggressive before merging? Tests all pass, but I note that the channel type and addressing now seem to be essentially the same thing. Is that intended?
Collaborator
Author
|
Thanks Oliver, all looks good. Yes, the channel type is an artifact of the earlier design. I left it there as it will be useful when extending to other platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the comments from the previous PR: