[CfToHandshake] Do not replace the same value twice#754
Open
[CfToHandshake] Do not replace the same value twice#754
Conversation
Member
Author
|
I pulled this out of #654. Does this still break FTD? @AyaElAkhras ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CfToHandshake, we are calling
inlineBlockBeforeafterreplaceAllUsesWith. Internally,inlineBlockBeforecallsConversionPatternRewriterImpl::replaceOp.dynamatic/lib/Conversion/CfToHandshake/CfToHandshake.cpp
Lines 1045 to 1050 in 13d273d
In the latest LLVM,
ConversionPatternRewriterImpl::replaceOpasserts that the value that's being replaced must not have already been replaced, which is not true in the logic above.To fix this, when constructing MC/LSQ, use the merge outputs directly rather than the block arguments for GAs and the number of stores. This omits the need to call
replaceAllUsesWith