[Handshake] Clean up generation of LSQ ordering/port information#788
[Handshake] Clean up generation of LSQ ordering/port information#788
Conversation
Previously, three configuration values (`ldOrder`, `ldPortIdx`, `stPortIdx`) used an unneeded special case if a group did not contain any load/store ports at all. There, a list with a single zero was used instead of the consistent empty list. This behavior is not being relied upon by the Python LSQ generator. Furthermore, the legacy Chisel-based generator does not use these config fields at all.
|
It turns out removing this was already discussed in #211. Back then, this "padding" was apparently still required by the Python generator. I have confirmed this is no longer the case: These configuration values are stored by the Python generator as dynamatic/tools/backend/lsq-generator-python/vhdl_gen/operators/mux.py Lines 139 to 151 in 80ffd77 If the |
Previously, three configuration values (
ldOrder,ldPortIdx,stPortIdx) used an unneeded special case if a group did not contain any load/store ports at all. There, a list with a single zero was used instead of the consistent empty list.This behavior is not being relied upon by the Python LSQ generator. Furthermore, the legacy Chisel-based generator does not use these config fields at all.