Mit expression by OmidOftadeh · Pull Request #5 · EPFL-LCSB/etfl

OmidOftadeh · 2020-02-13T11:28:47Z

Mitochondrial expression system

OmidOftadeh · 2020-02-13T16:11:53Z

Hi Pierre,
Indeed, I have changed 3 files to implement mitochondrial RNAP and ribosome.
Here is a description of changes in each file:

genes.py: the setters for transcribed_by and translated_by attributes are changed so they can be set if either the gene is not connected to a model or it is connected to a model, but synthesis constraint is not created yet.
memodel.py: two functions, add_translation_by and add_transcription_by were added to assign the corresponding RNAP and ribosome to each gene, respectively. Moreover, _populate_ribosome and _populate_rnap were modified to define a total capacity constraint per each ribosome and RNAP.
dict.py: it was modified so that regardless of type of transcribe_by and translated_by (either enzyme object or string) it can be converted to JSON file.

Cheer,
Omid

EDIT (by Pierre): formatting

psalvy · 2020-02-24T08:23:59Z

 from cobra import Gene
 from Bio.Seq import Seq
 from Bio.Alphabet import DNAAlphabet, RNAAlphabet, ProteinAlphabet
+from etfl.optim.constraints import SynthesisConstraint


change to
from ..optim.constraints import SynthesisConstraint

psalvy · 2020-02-24T08:24:58Z

+            else:
+                # We need to make the model change the corresponding cstr
+                mod_id = self.id + '_transcription'
+                Cstr = self.model.get_constraints_of_type(SynthesisConstraint)


please respect the conventions and use Uppercas names only for classes. variables are lowercase most of the time.

psalvy · 2020-02-24T08:26:08Z

+                try:
+                    Cstr.get_by_id(mod_id)
+                except KeyError:
+                    cstr_exist = 0


Please use True and False instead of 1 and 0

Also please add comments as to why you are doing this: checking that the genes are not transcribed yet.

psalvy · 2020-02-24T08:29:55Z

+                self._transcribed_by = value
+            else:
+                # We need to make the model change the corresponding cstr
+                mod_id = self.id + '_transcription'


Please replace by get_transcription_reaction_name

You mean I should write a new function to do this?

There is already a function for this here

psalvy · 2020-02-24T08:30:39Z

+                    cstr_exist = 0
+                if cstr_exist:
+                    # trancription constraint already exists
+                    raise NotImplementedError()


Please add #TODO with instructions

psalvy · 2020-02-24T08:30:52Z

    def translated_by(self,value):
        # TODO: Make this a setter that rewrites the adequate constraints
-        raise NotImplementedError()
+        if value != self._translated_by:


Same comments as before

psalvy · 2020-02-24T08:31:50Z

        :return:
        """
-
+        


can you please remove these empty lines containing only spaces

psalvy · 2020-02-24T08:32:34Z

+
+    def add_transcription_by(self, transcription_dict):
+
+        for gene_id, transcripted_by in transcription_dict.items():


Please rename transcripted_by into transcribed_by

psalvy · 2020-02-24T08:33:12Z

+            # transcripted_by is a list of rnap(s)
+            try:
+                self.genes.get_by_id(gene_id).transcribed_by = transcripted_by
+            except KeyError:


Please add a comment explaining in which case this error would happen

psalvy · 2020-02-24T08:35:06Z

        free_pep._model = self
        self.peptides += [free_pep]
+
+    def add_peptide_sequences(self, aa_sequences):


Can you remind me for which case you had to add this ?

This is a function that I have to add my peptide sequences. It's not related to mitochondrial expression. You can neglect it.

psalvy · 2020-02-24T08:38:31Z

-                     for x in self.rnap]
+        # only for genes trascribed by this rnap
+        sum_RMs = symbol_sum([x.unscaled for x in all_rnap_usage \
+                             if x.hook.transcribed_by is None \


Add a comment explaining why we include the None as well

psalvy · 2020-02-24T08:39:15Z

-                - sum([x.concentration for x in self.rnap.values()])
-        usage /= min([x.scaling_factor for x in self.rnap.values()])
+                - sum([self.rnap[rnap_id].concentration])
+        usage /= min([self.rnap[rnap_id].scaling_factor])


You can remove the min here, we do not have an iterable anymore

psalvy · 2020-02-24T08:39:56Z

                + sum([x.unscaled for x in free_rnap]) \
-                - sum([x.concentration for x in self.rnap.values()])
-        usage /= min([x.scaling_factor for x in self.rnap.values()])
+                - sum([self.rnap[rnap_id].concentration])


You can remove the sum here, we do not have a list anymore

psalvy · 2020-02-24T08:40:25Z

-        sum_RPs = symbol_sum([x.unscaled for x in all_ribosome_usage])
+        # only for genes traslated by this ribosome
+        sum_RPs = symbol_sum([x.unscaled for x in all_ribosome_usage \
+                              if x.hook.translated_by is None \


same as before

psalvy · 2020-02-24T08:54:34Z

+            if gene.translated_by is not None else None
+    except AttributeError:
+        obj['translated_by'] = [x for x in gene.translated_by] \
+            if gene.translated_by is not None else None            


I see no method to read that back from the dictionary ?

I will do this later ;)

psalvy · 2020-02-24T08:54:42Z

                g._peptide        = Seq(gene_dict['peptide'], alphabet=ProteinAlphabet())
                g._copy_number    = int(gene_dict['copy_number'])
-
+                


psalvy

Please go through the comments and implement the requested fixes. In particular:

You need to comment more your code
There is no method to read the transcribed_by / translated_by back from the dictionary upon serialization

…is solved

ENH: implement mitochondrial expression system

d5f94c2

OmidOftadeh force-pushed the mit_expression branch from 185af82 to d5f94c2 Compare February 13, 2020 15:42

psalvy added the enhancement New feature or request label Feb 13, 2020

psalvy self-assigned this Feb 13, 2020

psalvy self-requested a review February 13, 2020 16:30

psalvy reviewed Feb 24, 2020

View reviewed changes

Comment thread etfl/core/memodel.py Outdated

:return:

"""

Copy link
Copy Markdown

Member

psalvy Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove these empty lines containing only spaces

psalvy reviewed Feb 24, 2020

View reviewed changes

psalvy requested changes Feb 24, 2020

View reviewed changes

FIX: implemented the comments

605c00b

OmidOftadeh force-pushed the mit_expression branch from 8717f82 to 605c00b Compare February 28, 2020 18:54

FIX: the issue for the genes with several assigned ribosome and rnap …

2cd0619

…is solved

OmidOftadeh force-pushed the mit_expression branch from 80dcb00 to 2cd0619 Compare March 3, 2020 18:26

psalvy force-pushed the dev branch from a78593e to 5e5d8e8 Compare June 29, 2020 14:30


		def add_transcription_by(self, transcription_dict):

		for gene_id, transcripted_by in transcription_dict.items():

		g._peptide = Seq(gene_dict['peptide'], alphabet=ProteinAlphabet())
		g._copy_number = int(gene_dict['copy_number'])

Conversation

OmidOftadeh commented Feb 13, 2020

Uh oh!

OmidOftadeh commented Feb 13, 2020 • edited by psalvy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

psalvy Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

psalvy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

OmidOftadeh commented Feb 13, 2020 •

edited by psalvy

Loading

psalvy Feb 24, 2020 •

edited

Loading

psalvy left a comment •

edited

Loading