Remove continuous singletons from double-sided rows#2962
Open
Remove continuous singletons from double-sided rows#2962
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #2962 +/- ##
==========================================
+ Coverage 81.28% 81.32% +0.04%
==========================================
Files 358 358
Lines 88720 88724 +4
==========================================
+ Hits 72119 72159 +40
+ Misses 16601 16565 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
This is great, @Opt-Mucca! I would like to experiment with this a llittle more. Also, there is |
Collaborator
Author
|
@fwesselm I was worried that I was missing something, so please make any changes you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General idea: We currently have no explicit reduction for a column
s, with0cost, and that only appears in a single double-sided rowb_0 <= a^Tx + cs <= b_1. Dual fixing removes all cases whereb_0 == -kHighsInforb_1 == kHighsInf, but the column is left alone ifb_0andb_1are finite. Removing the column may allow additional reductions to be made.Motivation: I was playing around with an instance, trying to figure out why HiGHS wasn't making a reduction, and thought this would help (spoiler: it did not), but while doing so I stumbled upon an old TODO in the code with the exact suggestion.
@fwesselm Three major questions:
shas infinite bounds, but in theory we could handle that here. The issue is I'm not sure what to do with infinite values in postsolve.Edit: Need to look into the failing tests (they're passing locally.....). Windows does not like this change at all.