Updated build for external dependencies#2987
Closed
mathgeekcoder wants to merge 1 commit intoERGO-Code:mods-metisfrom
Closed
Updated build for external dependencies#2987mathgeekcoder wants to merge 1 commit intoERGO-Code:mods-metisfrom
mathgeekcoder wants to merge 1 commit intoERGO-Code:mods-metisfrom
Conversation
* Added RPATH for linux/osx to find library * Support for vcpkg BLAS on linux (OpenBLAS) and osx (accelerate, not tested - might not actually work as is) * Fixed type redefinition warning on metis * Fixed `template-depth` compile warning on C (not C++) files * Minor code cleanup (e.g., removed debug messages) * Added thread safety for dependency loading * Added `highspy._core.getExtrasLoadStatus` for debugging the library load * Added highspy COMPONENT to avoid pointless copy of header files * Tested with BUILD_SHARED_LIBS=ON/OFF and BUILD_SHARED_EXTRAS_LIB=ON/OFF and HIPO=ON/OFF (windows and linux) * Tested highspy and highspy-extras (windows and linux)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mods-metis #2987 +/- ##
=============================================
Coverage ? 81.65%
=============================================
Files ? 349
Lines ? 89050
Branches ? 0
=============================================
Hits ? 72713
Misses ? 16337
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mathgeekcoder
had a problem deploying
to
testpypi
GitHub Actions
Failure
mathgeekcoder
had a problem deploying
to
testpypi
GitHub Actions
Failure
Contributor
Author
|
Wow, so many failures. Perhaps I'm working on the wrong dev branch. |
Contributor
Author
|
Closing and replacing with #2989 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR is for mods-metis branch
template-depthcompile warning on C (not C++) fileshighspy._core.getExtrasLoadStatusfor debugging the library loadBUILD_SHARED_LIBS=ON/OFFandBUILD_SHARED_EXTRAS_LIB=ON/OFFandHIPO=ON/OFF(windows and linux)