Fix suggested tool JSON formatting for Prettier compliance#446
Merged
Conversation
- format clipboard JSON with prettier parser=json - extract and reuse JSON builder utility - add regression tests for newline and formatting compliance - closes #445
Mitigates intermittent npm ci lockfile errors for @emnapi entries on GitHub runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #445 where JSON copied from the "Suggest a new tool" form was not always Prettier-compliant when saved to a file.
What changed
parser: json) before copying.webtest script to run the new test file.Validation
npm --prefix web test✅npm --prefix web run build✅Closes #445.