Keep route saves child-only and routeIdx-driven#33
Merged
Conversation
Constraint: KFood route groups must keep an implicit Route 1 and avoid rendering branch locks beside materialized child routes. Rejected: Add a new route-index column in the Shopify app | the backend slot order is the source of truth. Confidence: high Scope-risk: moderate Directive: Render saved child routes as canonical rows; use root/branch rows only before child materialization. Tested: cd apps/shopify-app && node --test tests/routes-page.test.mjs Not-tested: Full Shopify npm test/typecheck; this worktree has no installed node_modules, so @shopify/shopify-app-react-router/react-router binaries are missing.
Constraint: Route groups must persist only child routes with server-authoritative global routeIdx; root and branch rows are legacy-only. Rejected: Keep synthetic root/branch rows in the Shopify draft UI | they reintroduced duplicate Route 1 rows and root-row validation failures. Confidence: high Scope-risk: moderate Directive: Do not restore root route rows or branchId draft payloads for route group saves; use child routeIdx assertions instead. Tested: npm test; npm run typecheck; npm run check:public-urls; npm run build Not-tested: Live K-food browser save flow and production deploy smoke are deferred to the next ultragoal stage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- remove active root/branch route composition from Shopify route detail saves\n- show/sort saved child routes by global routeIdx and include routeIdx assertions in draft payloads\n- keep Add Empty Route numbering based on the global context route set\n\n## Verification\n- npm test\n- npm run typecheck\n- npm run check:public-urls\n- npm run build