Use routeIdx markers for default labels#34
Merged
Conversation
Constraint: Default route labels should be compact #N names while preserving edited names.\nRejected: Add a shared formatter | the format appears in only the existing default-label spots.\nConfidence: high\nScope-risk: narrow\nDirective: Keep generated defaults as #N; do not parse names for routeIdx.\nTested: cd apps/shopify-app && node --test tests/routes-page.test.mjs tests/route-groups-helper.test.mjs; npm run typecheck; npm run build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- change Shopify default child-route labels from
Route Nto#N\n- keep routeIdx payload assertions and edited names unchanged\n\n## Tested\n- cd apps/shopify-app && node --test tests/routes-page.test.mjs tests/route-groups-helper.test.mjs\n- cd apps/shopify-app && npm run typecheck\n- cd apps/shopify-app && npm run build