Render route group rows from child metrics#35
Merged
Conversation
Constraint: Routes overview/detail must use routeMetrics only and render blanks for missing cache.\nRejected: Falling back to legacy ETA/distance fields | hides stale or guessed values.\nConfidence: high\nScope-risk: moderate\nDirective: Keep parent summary totals leaf-row based when parent rows display child aggregates.\nTested: cd apps/shopify-app && node --test tests/routes-page.test.mjs; npm run typecheck; npm run build; node --test tests/*.test.mjs; npm run check:public-urls.\nNot-tested: Browser iframe smoke after backend deploy.
Constraint: Route group detail rows must show child-route OSRM metrics and item totals after server draft-save cache generation.\nRejected: Reusing parent route summary values | group rows can hide missing child metrics and stale totals.\nConfidence: high\nScope-risk: narrow\nDirective: Keep routeIdx/#idx as server-owned identity and use childRoutePlan/childRouteMetrics for row totals.\nTested: node --test tests/routes-page.test.mjs tests/route-groups-helper.test.mjs; npm run typecheck; git diff --check\nNot-tested: Shopify app production deploy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shopify app route/OSRM row wiring.\n\nChanges:\n- Route group child rows use child route plan/metrics for Start time, Total items, Total drive time, and Total distance.\n- Stops derive item counts from child DTO item fields.\n- Keeps routeIdx/#idx draft save contract intact.\n\nIncluded branch history:\n- Show cached OSRM route metrics in admin routes\n- Render route group rows from child metrics\n\nVerified:\n- node --test tests/routes-page.test.mjs tests/route-groups-helper.test.mjs (53 passed)\n- npm run typecheck\n- git diff --check\n\nNot deployed; user requested commit and merge only.