This repository was archived by the owner on Dec 9, 2025. It is now read-only.
fix: Add extra check for etc path#312
Merged
Merged
Conversation
chrizap
marked this pull request as ready for review
November 26, 2025 16:44
chrizap
requested review from
Pietfried,
andistorm,
corneliusclaussen and
hikinggrass
as code owners
November 26, 2025 16:44
Member
|
Hi, I think you're missing a sign-off in your commit which means the DCO check fails, can you fix that? Apparently there's also a line that needs reformatting since clang-format complains :D thanks a lot! |
chrizap
force-pushed
the
fix/correct-etc-path
branch
from
November 27, 2025 07:48
510feb2 to
6937c00
Compare
hikinggrass
reviewed
Nov 28, 2025
hikinggrass
force-pushed
the
fix/correct-etc-path
branch
from
December 2, 2025 11:03
56d70f7 to
4619ad4
Compare
Signed-off-by: Christofer Gilje Skjæveland <christofer.skjaeveland@zaptec.com> Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
hikinggrass
force-pushed
the
fix/correct-etc-path
branch
from
December 2, 2025 11:05
4619ad4 to
7fbb64a
Compare
hikinggrass
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using a custom prefix ending with "usr" (e.g., /extra/usr), the etc directory path was incorrectly resolved to /extra/usr/etc instead of /extra/etc.
An extra check has been added which uses parent path as root directory for etc.
Test Cases
Prefix: /usr
Got: /etc
Prefix: /extra/usr
Got: /extra/etc
Prefix: /opt/usr
Got: /opt/etc
Prefix: /usr/local
Got: /usr/local/etc
Prefix: /extra
Got: /extra/etc
Prefix: /opt/myapp
Got: /opt/myapp/etc