Skip to content

Fix evolution CLI workspace DB scoping#95

Merged
EXboys merged 1 commit into
mainfrom
cursor/critical-bug-investigation-aeae
Jun 11, 2026
Merged

Fix evolution CLI workspace DB scoping#95
EXboys merged 1 commit into
mainfrom
cursor/critical-bug-investigation-aeae

Conversation

@cursor

@cursor cursor Bot commented Jun 10, 2026

Copy link
Copy Markdown

Summary

  • Fixes L2 evolution CLI/desktop JSON paths that ignored --workspace when opening the evolution SQLite DB.
  • Uses an explicit workspace-derived chat root in command-layer evolution paths instead of mutating process-global SKILLLITE_WORKSPACE.
  • Adds regressions for env-vs---workspace DB scoping and syncs EN/ZH L2 command docs.

Task Linkage

  • Task ID: TASK-2026-068
  • Task folder: tasks/TASK-2026-068-evolution-workspace-db-scope/

Injected Specs

  • spec/architecture-boundaries.md (if architecture/layering changed)
  • spec/security-nonnegotiables.md (if sandbox/security changed)
  • spec/testing-policy.md (required for any code change)
  • spec/docs-sync.md (if behavior/docs/env/commands changed)

Also followed: spec/verification-integrity.md, spec/task-artifact-language.md, spec/structured-signal-first.md, spec/capability-gap-evolution.md, spec/rust-conventions.md.

Validation Evidence

  • Commands executed:
    • rustup update stable && rustup default stable && rustc --version && cargo --version
    • cargo run -p skilllite -- --help
    • Seeded pre-fix and post-fix CLI repro with SKILLLITE_WORKSPACE=env and --workspace target
    • cargo fmt --check
    • cargo test -p skilllite-commands --features agent
    • cargo test -p skilllite --test cli_evolution_workspace
    • cargo clippy --all-targets -- -D warnings
    • cargo test -p skilllite
    • cargo test
    • python3 scripts/validate_tasks.py
  • Key results:
    • Pre-fix repro returned env_only and inserted authorization into env DB while --workspace pointed at target.
    • Post-fix repro returned target rows and inserted authorization into target DB only.
    • cargo test -p skilllite-commands --features agent: 39 passed; 0 failed.
    • cargo test -p skilllite --test cli_evolution_workspace: 1 passed; 0 failed.
    • cargo clippy --all-targets -- -D warnings: passed.
    • cargo test -p skilllite: passed.
    • cargo test: passed.
    • python3 scripts/validate_tasks.py: Task validation passed (68 task directories checked).

Regression Scope

  • Areas likely affected:
    • skilllite evolution backlog
    • skilllite evolution status
    • skilllite evolution proposal-status
    • skilllite evolution authorize-capability
    • desktop proposal-status bridge invocation
  • Explicit non-goals:
    • Broad evolution architecture refactors
    • SQLite schema changes
    • Workspace flag cleanup for legacy reset, disable, explain

Docs Sync (EN/ZH)

  • Not needed
  • Updated EN + ZH docs
  • Files:
    • docs/en/ASSISTANT-SPLIT-ARCHITECTURE.md
    • docs/zh/ASSISTANT-SPLIT-ARCHITECTURE.md

Review Checklist

  • Acceptance criteria in tasks/TASK-2026-068-evolution-workspace-db-scope/TASK.md satisfied
  • tasks/TASK-2026-068-evolution-workspace-db-scope/STATUS.md updated with latest progress
  • tasks/TASK-2026-068-evolution-workspace-db-scope/REVIEW.md includes merge readiness decision
  • tasks/board.md status is up to date
Open in Web View Automation 

Co-authored-by: EXboy <EXboys@users.noreply.github.com>
@EXboys EXboys marked this pull request as ready for review June 11, 2026 10:53
@EXboys EXboys merged commit 766e824 into main Jun 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants