Add-coverage-thresholds-per-critical-module#1777
Open
Habibah371 wants to merge 5 commits into
Open
Conversation
Add-coverage-thresholds-per-critical-module
|
@Habibah371 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Great job so far There’s are just two blockers — the workflow is failing and the conflict. Could you take a look and fix it so all checks pass? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR updates the test suite to ensure full compatibility with the project's strict TypeScript configuration by eliminating all
implicit anytypes and addressing related type-checking issues.Changes Made
noImplicitAnyviolations across test files.Testing
strictandnoImplicitAnyenabled.Impact
anytypes from masking potential bugs.Checklist
implicit anyoccurrences in tests.Closes [BE-019] Ensure strict TS config is compatible with all tests (no implicit any) #930
Closes [FE-034] Add coverage thresholds per critical module (
api,auth,env,hooks) #823