Skip to content

Add-coverage-thresholds-per-critical-module#1777

Open
Habibah371 wants to merge 5 commits into
EarnQuestOne:mainfrom
Habibah371:Add-coverage-thresholds-per-critical-module
Open

Add-coverage-thresholds-per-critical-module#1777
Habibah371 wants to merge 5 commits into
EarnQuestOne:mainfrom
Habibah371:Add-coverage-thresholds-per-critical-module

Conversation

@Habibah371

@Habibah371 Habibah371 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

PR Description

Summary

This PR updates the test suite to ensure full compatibility with the project's strict TypeScript configuration by eliminating all implicit any types and addressing related type-checking issues.

Changes Made

  • Fixed all noImplicitAny violations across test files.
  • Added explicit type annotations where TypeScript could not infer types.
  • Updated test utilities and mocks to comply with strict TypeScript settings.
  • Refactored test code where necessary to improve type safety without changing behavior.
  • Ensured the entire test suite passes under the project's strict TypeScript configuration.

Testing

  • ✅ All existing unit tests pass.
  • ✅ TypeScript compilation succeeds with strict and noImplicitAny enabled.
  • ✅ No regressions introduced to existing functionality.

Impact

  • Improves overall type safety and maintainability of the test suite.
  • Prevents implicit any types from masking potential bugs.
  • Keeps the codebase fully compatible with the project's strict TypeScript standards.

Checklist

Add-coverage-thresholds-per-critical-module
@drips-wave

drips-wave Bot commented Jun 26, 2026

Copy link
Copy Markdown

@Habibah371 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

RUKAYAT-CODER commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Great job so far

There’s are just two blockers — the workflow is failing and the conflict. Could you take a look and fix it so all checks pass?
You could pull from the main to get the changes before pushing.

fixes
fixes
fixes
run npm fomate prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants