feat: implement quest serialization contract and fix API fixture tests#1819
Open
Dydex wants to merge 2 commits into
Open
feat: implement quest serialization contract and fix API fixture tests#1819Dydex wants to merge 2 commits into
Dydex wants to merge 2 commits into
Conversation
|
@Dydex Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict and fix workflow |
Author
Done |
Author
|
@RUKAYAT-CODER Pls merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #826
This Pull Request addresses the serialization mismatch between the NestJS backend response and the frontend's expected type schema. Previously, the frontend Vitest suite mocked unwrapped payloads, failing to reflect the actual { data, meta } response envelope returned by the backend. Consequently, this PR implements a robust mapping and normalization layer to ensure the application correctly handles production payloads.
On the backend, QuestResponseDto has been updated to expose several required database columns that were previously omitted from the response, including contractQuestId (mapped from contractTaskId), rewardAsset, deadline, and completion counters. The entity mapping logic inside fromEntity has also been updated to ensure all these fields are correctly populated and sent in both single-quest and paginated listing endpoints.
On the frontend, the quest client endpoints (getQuests, getQuestById, createQuest, and updateQuest) have been wrapped with custom deserializeQuest and deserializePaginatedQuests helper functions. These helpers seamlessly handle both standard NestJS wrapped responses and the direct/unwrapped JSON fixture formats, while mapping backend-specific property keys to frontend-expected formats. In addition, the serializers handle type-coercion for numbers and normalize lowercase status strings (e.g., 'active') to frontend-specific capitalized enum values (e.g., 'Active').
Finally, the Vitest integration suite in quests.serialization.test.ts has been upgraded. All MSW mock handlers now wrap the test fixtures inside the authentic backend { data, meta } response envelope. This aligns the mock servers with the production API contracts, ensuring all assertions verify actual end-to-end serialization behavior.