Skip to content

fix: ensure minimum ulimits#10

Merged
gilescope merged 2 commits intomainfrom
giles-ci-fix
Feb 19, 2026
Merged

fix: ensure minimum ulimits#10
gilescope merged 2 commits intomainfrom
giles-ci-fix

Conversation

@gilescope
Copy link
Copy Markdown

@gilescope gilescope commented Feb 19, 2026

Attempt to fix build

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @gilescope, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical fix to prevent buildkitd from encountering resource starvation due to insufficient open file limits. By explicitly setting a higher minimum RLIMIT_NOFILE during initialization, the change ensures that the daemon has adequate file descriptors to operate efficiently, particularly in environments where default system limits might be lower than required.

Highlights

  • File Descriptor Limit: Implemented logic to ensure a minimum RLIMIT_NOFILE (open file limit) of 1048576 for the buildkitd process. This addresses potential starvation issues caused by lower default limits in newer Docker versions.
Changelog
  • cmd/buildkitd/main_unix.go
    • Added code to check and raise the RLIMIT_NOFILE (open file limit) to a minimum of 1048576 during init() to prevent buildkitd starvation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2026

➖ Are we earthbuild yet?

No change in "earthly" occurrences

📈 Overall Progress

Branch Total Count
main 217
This PR 217
Difference +0

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a fix to ensure that the open file limit (ulimit) for buildkitd is set to a minimum of 1048576. This addresses an issue where Docker 29+ (containerd v2) lowered the default limit, potentially starving buildkitd. The change correctly checks the current limit and raises it if necessary, ensuring proper operation. The code is well-commented and directly addresses the identified problem.

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope merged commit c40c767 into main Feb 19, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant