Skip to content

update all shadcn components#599

Merged
lazarusA merged 2 commits intomainfrom
la/breaking_shadcn
Mar 18, 2026
Merged

update all shadcn components#599
lazarusA merged 2 commits intomainfrom
la/breaking_shadcn

Conversation

@lazarusA
Copy link
Member

since we started using shadcn no updates had been done to components, and since recently there was a whole breaking release, which changes styles and imports I think is due time to do an update.

  • npx shadcn@latest migrate radix
  • update package.json accordingly, since a lot of packages now are integrated in radix directly
  • moved out the ripple logic for the button such any future updates to the shadcn button component are possible without affecting this enhancement.
  • update calls to this new button

TODO: in a cleanup PR.

  • for the button we should simply use the one from the index, which already imports the enhanced one.
  • deprecated our slider with multiple thumbs.... shadcn now supports that.

dev-note.

browzarr > rm -rf node_modules
browzarr> rm package-lock.json
npm install

(install also in your system pnpm if issues appear)

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the application's UI infrastructure by updating all Shadcn UI components to their latest versions, addressing a recent breaking release. The update streamlines dependencies, introduces a host of new UI components, and refactors custom button logic to improve maintainability and ensure compatibility with future library enhancements. This foundational change modernizes the user interface and prepares the codebase for continued development with up-to-date tools.

Highlights

  • Shadcn UI Component Update: All Shadcn UI components have been updated to their latest versions, incorporating recent breaking changes and improvements, including a migration to the new Radix-based structure.
  • Dependency Management Streamlined: The package.json file has been updated to reflect the new dependency structure, removing individual @radix-ui/react-* packages as they are now integrated directly into the core Radix UI library.
  • Custom Button Logic Refactored: The custom ripple effect logic for buttons has been extracted into a new button-enhanced component. This change isolates custom enhancements, allowing for smoother future updates to the core Shadcn button component without interference.
  • Button Usage Migration: All existing instances of the Button component across the application have been updated to import and utilize the newly created button-enhanced component.
  • New UI Components Introduced: Several new Shadcn UI components have been added, including AlertDialog, AspectRatio, Avatar, Breadcrumb, Calendar, Carousel, Chart, Checkbox, Combobox, ContextMenu, Direction, Empty, Field, Form, HoverCard, InputGroup, InputOTP, Item, Kbd, Label, Menubar, NativeSelect, NavigationMenu, Pagination, Progress, RadioGroup, Resizable, Sheet, Sidebar, Skeleton, Spinner, Tabs, Textarea, Toggle, and ToggleGroup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates all shadcn components to a newer version, which includes a significant breaking release. The changes are extensive, touching dependency management in package.json, global styles, and numerous UI components. Key improvements include:

  • Migrating from individual @radix-ui packages to the consolidated radix-ui meta-package.
  • Refactoring the custom ripple effect for buttons into a dedicated button-enhanced.tsx wrapper, which improves maintainability and makes future shadcn updates easier.
  • Adding and updating a large number of shadcn components, bringing in new features and styles.
  • Correctly setting up the global TooltipProvider in the root layout.

The overall implementation is solid and well-executed. I have one suggestion regarding dependency pinning in package.json to ensure build reproducibility.

@lazarusA lazarusA merged commit 72296ae into main Mar 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant