(WIP) Fix the default sorting of associated entities#5345
Open
javiereguiluz wants to merge 1 commit into
Open
Conversation
Seb33300
reviewed
Feb 17, 2026
Comment on lines
+160
to
+177
| if ($entityDto->isAssociation($field->getProperty())) { | ||
| $associatedProperties = explode('.', $field->getProperty()); | ||
| for ($i = 0; $i < \count($associatedProperties); $i++) { | ||
| $property = $associatedProperties[$i]; | ||
| if (!$entityDto->hasProperty($property)) { | ||
| return false; | ||
| } | ||
|
|
||
| // try to get the entity associated to the property, except for the last property | ||
| if (isset($associatedProperties[$i + 1])) { | ||
| $propertyMetadata = $entityDto->getPropertyMetadata($property); | ||
| $targetEntity = $propertyMetadata->get('targetEntity'); | ||
| $entityDto = $this->entityFactory->create($targetEntity); | ||
| } | ||
| } | ||
|
|
||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
I feel like the logic to handle associations is re implemented in many places and we should find a way to implement it in a reusable way across searching, filtering and ordering.
Another implementation supporting embedded is here:
EasyAdminBundle/src/Orm/EntityRepository.php
Line 260 in d89d3fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4875.
It's WIP because I still see some bugs.