[PERF-339] Performance test fixes for DS 5 and DMS#121
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates performance tests to align with changes introduced in EdFi Data Standard v5 and Data Management Service (DMS). The changes primarily address descriptor URI casing requirements and extend resource factories with additional fields for API compatibility.
Key changes:
- Fixed descriptor URI casing to match DMS case-sensitive requirements
- Added
gradingPeriodNamefield to grading period references for v5 compatibility - Enhanced resource factories with additional fields to support API over-posting
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| student.py (tasks/volume) | Added conditional graduation plan reference handling and additional fields for student school association |
| section.py (tasks/volume) | Removed redundant section scenario test case |
| course_offering.py (tasks/volume) | Removed specific course offering test scenario |
| course.py (tasks/volume) | Fixed descriptor URI casing for CourseLevelCharacteristic |
| student.py (tasks/pipeclean) | Changed serialNumber from integer to string type |
| utils.py | Updated random school year range from 2050 to 2026 |
| Multiple factory files | Added gradingPeriodName fields and fixed descriptor URI casing |
| Multiple client files | Extended API calls with additional required fields for v5 compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| graduation_plan_reference = None | ||
| graduationSchoolYear = StudentSchoolAssociationVolumeTest.get_graduation_plan_school_year(self, school_id) | ||
| if(graduationSchoolYear is not None): |
There was a problem hiding this comment.
Remove the unnecessary parentheses around the condition. Python style guide recommends if graduationSchoolYear is not None: instead of if(graduationSchoolYear is not None):.
Suggested change
| if(graduationSchoolYear is not None): | |
| if graduationSchoolYear is not None: |
JBrenesSimpat
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the GradingPeriod key to align with changes introduced in v5. Since the API permits over-posting, I extended the base resources to include additional fields for compatibility.
Descriptor URIs in DMS are currently case-sensitive. I adjusted the test cases to correct casing issues. A follow-up update to DMS will enable case-insensitive handling of descriptor URIs.