Merged
Conversation
Contributor
Author
|
This PR replaces #36 which was merged before cleaning up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Medium Risk
Changes how
syncedDocument.syncbehaves when the cleaner throws, which can affect what gets written back to CouchDB and what in-memory state is retained. Risk is mitigated by new unit tests but could impact consumers relying on previous failure semantics.Overview
Adds optional
SyncedDocumentOptionstosyncedDocument, allowing callers to control cleaner failure behavior viacleanFailStrategy(resetto defaults orpreservelast good value) and anonCleanFailcallback.Updates
syncedDocument.syncto catch cleaner exceptions, invokeonCleanFail, and choose the fallback document based on the configured strategy before continuing the usual repair/writeback flow. Includes a new test suite covering creation, dirty repair, change notifications, and both failure strategies, and documents the change inCHANGELOG.md.Written by Cursor Bugbot for commit 20b3564. This will update automatically on new commits. Configure here.