Add opt-in PostgreSQL name length limit support#6503
Conversation
🦋 Changeset detectedLatest commit: 04f3901 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a Changesets entry for ChangesSQL identifier limit release metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Comment |
|
I decided to add this as an opt-in option because I didn't want to break existing installs, but I could see down the road this becomes a default option. |
|
Looks like the branch needs a clean rebase. |
Long table, index and constraint names get silently truncated in Postgres and this could lead to collisions. Short names within the length limit are unchanged.
2e74d1f to
04f3901
Compare
|
@tim-smart i've rebased it on top of main. Would love a backport to the v3 branch. |
Long table, index and constraint names get silently truncated in Postgres and this could lead to collisions. Short names within the length limit are unchanged.
Type
Description
Depending on a user-provided "prefix" for the workflow cluster, it is possible that the generated names for tables, indices and constraints are too long for Postgres and will be cut-off or lead to execution errors.
Summary by CodeRabbit
limitIdentifierssetting for SQL message storage.