fix(formatter): stringify bigint values in JSON diagnostics#6546
fix(formatter): stringify bigint values in JSON diagnostics#6546xianjianlf2 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 376aad8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesBigInt JSON formatting
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Comment |
Fixes #4662
Summary
BigIntvalues with annsuffix inFormatter.formatJsoninstead of lettingJSON.stringifythrowformatJsonandInspectable.toStringUnknownTests
pnpm test packages/effect/test/Formatter.test.tspnpm lint-fixpnpm checkSummary by CodeRabbit
nsuffix, including when nested in arrays.