Skip to content

fix(ai): encode system messages as input text #6549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xianjianlf2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ai): encode system messages as input text #6549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-openai-system-input-text.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/ai-openai": patch
---

Encode OpenAI Responses API system messages as typed input text content.
2 changes: 1 addition & 1 deletion packages/ai/openai/src/OpenAiLanguageModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ const prepareMessages = Effect.fnUntraced(
case "system": {
messages.push({
role: getSystemMessageMode(config.model as string),
content: message.content
content: [{ type: "input_text", text: message.content }]
})
break
}
Expand Down
10 changes: 8 additions & 2 deletions packages/ai/openai/test/OpenAiLanguageModel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ describe("OpenAiLanguageModel", () => {

const systemMessage = body.input.find((m: any) => m.role === "system")
assert.isDefined(systemMessage)
strictEqual(systemMessage.content, "You are a helpful assistant")
deepStrictEqual(systemMessage.content, [{
type: "input_text",
text: "You are a helpful assistant"
}])
}).pipe(Effect.provide(makeTestLayer())))

it.effect("uses developer role for reasoning models", () =>
Expand All @@ -63,7 +66,10 @@ describe("OpenAiLanguageModel", () => {

const devMessage = body.input.find((m: any) => m.role === "developer")
assert.isDefined(devMessage)
strictEqual(devMessage.content, "You are a helpful assistant")
deepStrictEqual(devMessage.content, [{
type: "input_text",
text: "You are a helpful assistant"
}])
}).pipe(Effect.provide(makeTestLayer({ body: { model: "o1" } }))))

it.effect("uses developer role for gpt-5 models", () =>
Expand Down