Skip to content

Fix namespace reexport auto-imports#396

Open
mattiamanzati wants to merge 1 commit into
mainfrom
fix/namespace-reexport-auto-import
Open

Fix namespace reexport auto-imports#396
mattiamanzati wants to merge 1 commit into
mainfrom
fix/namespace-reexport-auto-import

Conversation

@mattiamanzati

Copy link
Copy Markdown
Contributor

Summary

  • distinguish namespace-valued reexports from ordinary top-level named reexports in namespaceImportPackages handling
  • resolve namespace reexport targets through TypeScript module-specifier generation so package exports and editor preferences are preserved
  • add policy and end-to-end completion/import-fix regression coverage

Behavior

Accepting the Effect completion now changes the generated import from:

import { Effect } from "effect"

to:

import * as Effect from "effect/Effect"

Testing

  • pnpm setup-repo
  • pnpm lint
  • pnpm check
  • pnpm test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant