Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-diagnostics-binary-permissions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/tsgo": patch
---

Ensure the packaged diagnostics binary is executable immediately before launch instead of relying on file permissions preserved during publishing.
2 changes: 1 addition & 1 deletion .changeset/update-typescript-go.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"@effect/tsgo": patch
---

Update to [`typescript@next`](https://www.npmjs.com/package/typescript/v/7.1.0-dev.20260723.1), which ships [`typescript-go`](https://github.com/microsoft/typescript-go/commit/4e25827a509ade0b8f48a690e9538be74fb491a6) commit `4e25827a509ade0b8f48a690e9538be74fb491a6`.
Update to [`typescript@next`](https://www.npmjs.com/package/typescript/v/7.1.0-dev.20260725.1), which ships [`typescript-go`](https://github.com/microsoft/typescript-go/commit/8d29e62f3585c2fb5179e4412895aa3a8f40b9f5) commit `8d29e62f3585c2fb5179e4412895aa3a8f40b9f5`.
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ jobs:
else
cp "${artifact_dir}/${binary_name}" "${package_dir}/${binary_name}"
cp "${artifact_dir}/${binary_name}.json" "${package_dir}/${binary_name}.json"
chmod 0755 "${package_dir}/${binary_name}"
test -x "${package_dir}/${binary_name}"
fi
done

Expand Down
4 changes: 4 additions & 0 deletions _packages/tsgo/src/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,12 @@ const diagnosticsCommand = Command.make("diagnostics", {
Command.withDescription("Gets the Effect language service diagnostics on the given files or project"),
Command.withHandler(({ file, format, lspconfig, progress, project, severity, strict }) =>
Effect.gen(function*() {
const fs = yield* FileSystem.FileSystem
const installedTypeScript = yield* resolveInstalledTypeScriptBinary(defaultTypescriptPackageNames)
const binaryPath = yield* getPackagedBinaryPath(installedTypeScript, false)
yield* fs.chmod(binaryPath, 0o755).pipe(
Effect.mapError(() => new ChmodBinaryError({ targetPath: binaryPath }))
)
const result = runDiagnosticsBinary(binaryPath, {
cwd: process.cwd(),
file: Option.getOrUndefined(file),
Expand Down
1 change: 1 addition & 0 deletions _tools/gen_shims/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ func main() {
"execute/tsc",
"format",
"fourslash",
"locale",
"ls",
"ls/autoimport",
"ls/change",
Expand Down
2 changes: 1 addition & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
/* Source of truth: git submodule `typescript-go` commit.
Keep in sync via `_tools/update-flake-vendor-hash.sh`. */
typescript-go-src = {
url = "github:microsoft/typescript-go/4e25827a509ade0b8f48a690e9538be74fb491a6?submodules=1";
url = "github:microsoft/typescript-go/8d29e62f3585c2fb5179e4412895aa3a8f40b9f5?submodules=1";
flake = false;
};
/* Source of truth: typescript-go's `_submodules/TypeScript` commit.
Expand Down
2 changes: 2 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ replace (
github.com/microsoft/typescript-go/shim/execute/tsc => ./shim/execute/tsc
github.com/microsoft/typescript-go/shim/format => ./shim/format
github.com/microsoft/typescript-go/shim/fourslash => ./shim/fourslash
github.com/microsoft/typescript-go/shim/locale => ./shim/locale
github.com/microsoft/typescript-go/shim/ls => ./shim/ls
github.com/microsoft/typescript-go/shim/ls/autoimport => ./shim/ls/autoimport
github.com/microsoft/typescript-go/shim/ls/change => ./shim/ls/change
Expand Down Expand Up @@ -58,6 +59,7 @@ require (
github.com/microsoft/typescript-go/shim/diagnostics v0.0.0-00010101000000-000000000000
github.com/microsoft/typescript-go/shim/execute/tsc v0.0.0-00010101000000-000000000000
github.com/microsoft/typescript-go/shim/fourslash v0.0.0
github.com/microsoft/typescript-go/shim/locale v0.0.0
github.com/microsoft/typescript-go/shim/ls v0.0.0-00010101000000-000000000000
github.com/microsoft/typescript-go/shim/ls/autoimport v0.0.0-00010101000000-000000000000
github.com/microsoft/typescript-go/shim/ls/change v0.0.0-00010101000000-000000000000
Expand Down
1 change: 1 addition & 0 deletions go.work
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ use (
./shim/diagnostics
./shim/format
./shim/fourslash
./shim/locale
./shim/ls
./shim/ls/autoimport
./shim/ls/change
Expand Down
5 changes: 5 additions & 0 deletions internal/effecttest/document_symbols_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/effect-ts/tsgo/internal/bundledeffect"
"github.com/microsoft/typescript-go/shim/bundled"
"github.com/microsoft/typescript-go/shim/diagnostics"
"github.com/microsoft/typescript-go/shim/locale"
"github.com/microsoft/typescript-go/shim/ls/lsconv"
"github.com/microsoft/typescript-go/shim/lsp/lsproto"
"github.com/microsoft/typescript-go/shim/project"
Expand Down Expand Up @@ -232,3 +233,7 @@ func (noopProjectClient) ProgressFinish(_ *diagnostics.Message, _ ...any) {}
func (noopProjectClient) SendTelemetry(_ context.Context, _ lsproto.TelemetryEvent) error { return nil }

func (noopProjectClient) IsActive() bool { return true }

func (noopProjectClient) SetLocale(_ string) {}

func (noopProjectClient) GetLocale() locale.Locale { return locale.Default }
5 changes: 5 additions & 0 deletions shim/locale/go.mod
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module github.com/microsoft/typescript-go/shim/locale

go 1.26

require github.com/microsoft/typescript-go v0.0.0
17 changes: 17 additions & 0 deletions shim/locale/shim.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.