feat: add promise success diagnostic

[mattiamanzati]

Summary

• add the promiseInEffectSuccess correctness diagnostic for Effect v3 and v4
• inspect strict Effect<A, E, R> success channels across runtime expressions and report native Promise members, including unions
• use resolved call return types and innermost-expression deduplication so custom factories, generators, property access, and Effect combinators are covered
• preserve explicitly intentional Effect<Promise<...>> annotations, return types, assertions, and success-producing generic arguments

Example

declare const save: (value: number) => Promise<void>

const program = Effect.succeed(1).pipe(
  Effect.map(save)
)
//                ^ Effect success channel contains an unawaited Promise

The diagnostic recommends representing the asynchronous work with Effect.promise or Effect.tryPromise. Strict Promise identity intentionally excludes PromiseLike and arbitrary thenables.

Validation

• pnpm setup-repo
• pnpm lint
• pnpm check
• pnpm test

Closes #405