Fix outdated imports and fix convergence in tabular cfr#3
Open
svtuck wants to merge 1 commit intoEgiob:developfrom
Open
Fix outdated imports and fix convergence in tabular cfr#3svtuck wants to merge 1 commit intoEgiob:developfrom
svtuck wants to merge 1 commit intoEgiob:developfrom
Conversation
2. Fix a bug in tabular cfr that caused it to not converge to the correct cfr for leduc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For leduc this was not converging
because we were passing the wrong vector to children.
with the fix we get
which is the right leduc nash ev