Skip to content

🎨 Palette: Improve screen reader accessibility for score and add jump instructions #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EiJackGH wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Improve screen reader accessibility for score and add jump instructions #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@
## 2025-03-23 - Game Key Scrolling
**Learning:** Browsers natively scroll the page when users press Space or Arrow keys. When building a web-based game, this creates a frustrating UX where the game viewport jumps around while playing.
**Action:** Always call `e.preventDefault()` on keydown events for typical game controls ("Space", "ArrowUp", etc.) when the focus is on a game container or the body.
## 2024-07-18 - [Accessible Instructional Overlays]
**Learning:** Adding static instructional text next to dynamic `aria-live` content provides immediate clarity for keyboard users without causing screen readers to re-read the static text. Overlay text must use `pointer-events: none` to ensure it doesn't intercept or block mouse clicks/touches on the game canvas below.
**Action:** Extract dynamic values into dedicated `<span>`s with ARIA live attributes. Ensure instructional overlays are visually distinct and explicitly ignore pointer events.
21 changes: 17 additions & 4 deletions src/views/mario-game.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,29 +44,42 @@
background: #2ecc71;
}

#score {
#score-container {
position: absolute;
top: 10px;
left: 10px;
color: white;
font-size: 20px;
font-family: Arial;
}

#instructions {
position: absolute;
top: 10px;
right: 10px;
color: white;
font-size: 20px;
font-family: Arial;
pointer-events: none;
}
</style>
</head>

<body>

<div id="game">
<div id="score">Score: 0</div>
<div id="score-container">
<span id="score-label">Score: </span><span id="score-value" aria-live="polite" aria-atomic="true">0</span>
</div>
<div id="instructions">Press Space or Up Arrow to jump</div>
<div id="mario"></div>
<div class="ground"></div>
</div>

<script>
const mario = document.getElementById("mario");
const game = document.getElementById("game");
const scoreText = document.getElementById("score");
const scoreValue = document.getElementById("score-value");

let jumping = false;
let score = 0;
Expand Down Expand Up @@ -118,7 +131,7 @@
clearInterval(move);
goomba.remove();
score++;
scoreText.innerText = "Score: " + score;
scoreValue.innerText = score;
} else {
position -= 6;
goomba.style.left = position + "px";
Expand Down