Clean up .claude config: fix broken paths, dedupe tool docs, sync livetools skill#18
Merged
Conversation
…etools skill - Fix static-analyzer agent pointing at .claude/rules/tool-catalog.md (actual location is .claude/references/tool-catalog.md) - Add missing livetools commands to the dynamic-analysis skill: dipcnt, memwatch, vishook, gamectl, mem alloc - Make each tool list single-source: inline allowlist lives in tool-dispatch.md, DX script table in tool-catalog.md, livetools syntax in the dynamic-analysis skill; other docs point instead of copy - Rewrite both skill descriptions as trigger-only (no workflow summary) - Add shared .claude/settings.json permission allowlist; untrack and gitignore settings.local.json
Apply the .claude config fixes to the parallel .cursor, .kiro, and .github instruction trees, and back-port improvements that only existed there: - Fix broken tool-catalog path in .kiro and .github static-analyzer agents (pointed at nonexistent .claude/rules/tool-catalog.md; now point at their own tree's catalog) - Back-port into the canonical .claude dynamic-analysis skill: hook-address verification recipe, address rebasing guidance, 'hook the game's CALL, not the DLL function' and 'zero hits = diagnose' patterns, and the Anti-Patterns section - Propagate the canonical skill bodies (dynamic-analysis, dx9-ffp-port) to .cursor skills, .kiro powers, and .github skills; the dx9-ffp-port copies predated the template-copy workflow - Add missing livetools commands (vishook, gamectl, mem alloc) to all IDE tool catalogs and decision guides - Rebuild the .github tool catalog from the current content (it predated the pyghidra backend entirely) - Fix stale ffp_proxy.log references (actual path is rtx_comp/diagnostics.log) and note the INI lives in assets/
…threshold Review fixes for this PR: - Back-port content the dx9-ffp-port sync deleted from the .cursor/.kiro/ .github copies without first folding it into the canonical .claude skill: the "Skinning Stability: Finding Game-Specific Hook Points" workflow, the "Bones mixed up between NPCs" pitfall, and the stages 1-7 disabling detail (verified against ffp_state.cpp). Propagated to all four trees; bodies remain identical across trees. - Note in all four dynamic-analysis skills that vishook --threshold is parsed as hex (agent.js parseInt(..., 16)): default 500000 = 0x500000. - Update .github dx9-ffp-port frontmatter description to the trigger-style wording used by the other trees.
d9323f7 to
2bee974
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit fixes for the
.claude/configuration — one real bug, several doc-drift issues, dedup of tool lists — plus a full sync of the parallel.cursor,.kiro, and.githubinstruction trees per the CODE_REVIEW.md checklist.Commit 1 — .claude cleanup
Bug fixes
.claude/rules/tool-catalog.md; the catalog lives at.claude/references/tool-catalog.md.dipcnt,memwatch,vishook,gamectl, andmem allocexist in the CLI but were missing from the skill. Added quick-reference and command-detail sections written from the actual argparse definitions.Dedup (single source of truth per list)
pyghidra_backend.py status); CLAUDE.md states the rule and points there.Skill description hygiene
Both skill descriptions are now trigger-only ('Use when...') with no workflow summary.
Settings
.claude/settings.jsonpermission allowlist covering the documented inline workflows.settings.local.jsonuntracked and gitignored; its git permissions migrated into the shared file.Commit 2 — IDE tree sync (CODE_REVIEW.md checklist)
.kiroand.githubstatic-analyzer agents pointed at the nonexistent.claude/rules/tool-catalog.md; they now point at their own tree's catalog..claudedynamic-analysis skill: hook-address verification recipe, ASLR rebasing guidance, "hook the game's CALL instruction, not the DLL function" and "zero hits = diagnose, don't give up" patterns, and the Anti-Patterns section..cursor/skills,.kiro/powers, and.github/skills, preserving each tree's frontmatter format. The dx9-ffp-port copies predated the template-copy workflow entirely (described editingrtx_remix_tools/dx/remix-comp-proxy/directly).rtx_comp/diagnostics.log(10 references saidffp_proxy.log); the INI template lives inassets/.