Skip to content

Fix 16-bit export bugs and UI inconsistencies#103

Draft
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
bugfix/export-logic-and-ui-14730134697541194837
Draft

Fix 16-bit export bugs and UI inconsistencies#103
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
bugfix/export-logic-and-ui-14730134697541194837

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

This submission addresses critical bugs in the Material Baker plugin.

  1. 16-bit Export Fix: The export pipeline for PNG and TGA formats previously wrote raw Float16 data to files expected to be UNORM16. This resulted in corrupted/unreadable images. The fix implements a proper conversion step that quantizes linear floating-point data to 16-bit integers (0-65535). It also includes a high-precision sRGB conversion path (using pow(x, 1/2.2)) to ensure 16-bit data is not crushed to 8-bit precision before saving.
  2. UI Logic Correction: The logic for enabling/disabling bit depth options (e.g., forcing 8-bit for JPEG) was previously only triggered when changing Compression Settings, not Output Type. This logic has been centralized in UpdateUIToReflectOutputType and hooked up correctly. Additionally, the code now explicitly updates the visible selection of the SComboBox to match the internal state, preventing misleading UI states.
  3. Configuration Alignment: Added the missing JPEG output option and removed the Normal property to strictly adhere to the "Minimum Configuration" requirements specified in the documentation/memory.
  4. Tests: Added MaterialBakerTests.cpp to verify constant availability and export logic correctness (compile-only verification in this env).

PR created automatically by Jules for task 14730134697541194837 started by @EmbarrassingMoment

- Fixed critical bug in 16-bit PNG/TGA export where float data was incorrectly passed as integer data.
- Implemented high-precision sRGB conversion for 16-bit export to avoid 8-bit quantization artifacts.
- Corrected UI logic to properly update the Bit Depth dropdown selection when constrained by Output Type.
- Added support for JPEG export to the Minimum Configuration.
- Removed unsupported 'Normal' property from the UI.
- Updated CHANGELOGs (EN/JP).
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants