Open
Conversation
noahsmartin
reviewed
Sep 26, 2024
| #endif | ||
|
|
||
| @available(iOS 18.0, macOS 15.0, tvOS 18.0, watchOS 11.0, *) | ||
| public struct PreviewModifierContextCache { |
Member
There was a problem hiding this comment.
Does this need to be public?
Contributor
Author
There was a problem hiding this comment.
Right now I am loading the data into the case from SnapshotCore: https://github.com/EmergeTools/SnapshotPreviews-iOS/pull/203/files#diff-57ad2b1c1655ee3a13c85b873055ca76dbf97b83eb5d07583353e130bf2be3daR117
But I can refactor this
noahsmartin
reviewed
Sep 26, 2024
| } | ||
|
|
||
| @available(iOS 18.0, macOS 15.0, tvOS 18.0, watchOS 11.0, *) | ||
| public struct AnyPreviewModifier: PreviewModifier { |
Member
There was a problem hiding this comment.
Same with this, does it need to be public?
…to feature/swiftui_preview_modifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.