Use SnapshotPreviews from `Cameroncooke/snapshots ci` branch by cameroncooke · Pull Request #780 · EmergeTools/hackernews

cameroncooke · 2026-04-01T14:58:27Z

This branch exists just to test the ~~unreleased~~ now merged changes to SnapshowPreviews on the here: EmergeTools/SnapshotPreviews#252

See workflow run which is using SnapshotPreviews with CI export functionality:
https://github.com/EmergeTools/hackernews/actions/runs/23857485626/job/69554642234?pr=780

Resulting Sentry Snapshots URL:
https://sentry.sentry.io/preprod/snapshots/177173/

emerge-tools · 2026-04-03T08:50:42Z

📸 Snapshot Test

1 modified, 71 unchanged

Name	Added	Removed	Modified	Renamed	Unchanged	Errored	Approval
HackerNews com.emergetools.hackernews.snapshots	0	0	1	0	71	0	⏳ Needs approval

🛸 Powered by Emerge Tools

sentry · 2026-04-03T08:51:01Z

📲 Install Builds

iOS

🔗 App Name	App ID	Version	Configuration
HackerNews	com.emergetools.hackernews	3.10 (1)	Release
HackerNews	com.emergetools.hackernews	3.10 (1)	AdHoc

⚙️ launchpad-test-ios Build Distribution Settings

…p crash The test process working directory differs from the shell's, so a relative path caused the SnapshotCIExportCoordinator to fail creating the export directory, triggering a preconditionFailure (SIGTRAP) during test bootstrapping. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…ately Move TEST_RUNNER_SNAPSHOTS_EXPORT_DIR and XCODE_RUNNING_FOR_PREVIEWS into the job-level env block so both iPhone and iPad test steps share the same absolute export path. Add a dedicated boot step for the iPad simulator and clarify the existing boot step name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Run the snapshot upload workflow on PRs targeting main in addition to pushes, scoped to ios and workflow file paths for both triggers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add upload_sentry_preview_snapshots lane that uploads snapshot images generated by SnapshotPreviews to Sentry, separate from the existing swift-snapshot-testing upload lane. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add branch-scoped DerivedData caching and split the single xcodebuild test into build-for-testing + test-without-building to improve CI wall-clock time and give better visibility into build vs test duration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Move sim boot before cache steps so it boots during cache restore - Pin DerivedData to a fixed path with -derivedDataPath so cache reliably hits across runs - Add -skipPackageUpdates to avoid ~2min SPM resolution (Package.resolved is committed) - Enable COMPILATION_CACHING, EAGER_LINKING, FUSE_BUILD_SCRIPT_PHASES for faster incremental and zero-change builds - Strip redundant build settings from test-without-building step - Simplify SPM cache path (DD cache now covers SourcePackages) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

DerivedData cache already contains SourcePackages, and -skipPackageUpdates prevents xcodebuild from fetching. The SPM cache was downloading 759MB for no benefit — removing it saves ~4 minutes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The split into build-for-testing + test-without-building was paying ~2min xcodebuild startup tax twice. For 23 snapshot tests that run in 10s, the visibility tradeoff isn't worth ~1min of added overhead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

-skipPackageUpdates prevents xcodebuild from fetching new commits when Package.resolved changes, causing failures. Since the DD cache is keyed on branch name (not Package.resolved), we need to allow SPM to fetch deltas. -skipPackagePluginValidation still skips plugin trust prompts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

DerivedData cache download time was too variable (1.5-5 min) on GHA network, often outweighing build savings. Restore the original SPM cache which is smaller and more predictable. Keep COMPILATION_CACHING and other build settings which work independently of DD caching. Also removed -derivedDataPath to use default location (matches SPM cache paths). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

xcodebuild was matching both arm64 and x86_64 for the same simulator, triggering a warning and potentially slowing destination resolution. Pinning arch=arm64 eliminates the ambiguity on Apple Silicon runners. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Add a new GitHub Actions workflow that runs SwiftSnapshotTest and uploads the generated images to Sentry. Recording is controlled via the SNAPSHOT_TESTING_RECORD env var instead of hardcoding record: .all in the test file, so local runs default to reference comparison while CI always records fresh snapshots. - New workflow: ios_sentry_upload_swift_snapshots.yml - Remove invokeTest() override from SwiftSnapshotTest.swift - Use continue-on-error on test step since record mode fails assertions Refs EME-1030 Co-Authored-By: Claude <noreply@anthropic.com>

sentry · 2026-04-15T12:24:57Z

Sentry Snapshot Testing

Name	Added	Removed	Modified	Renamed	Unchanged	Status
com.emergetools.hackernews `com.emergetools.hackernews`	0	0	0	0	18	✅ Unchanged

⚙️ hackernews-ios Snapshot Settings

NicoHinderling · 2026-04-16T16:58:07Z

-      super.invokeTest()
-    }
-  }
-


intentional?

@NicoHinderling Yes, because Swift Snapshot Testing does diffing locally, we would only want to enable recording on CI workflows. We use an environmental variable in the GitHub workflow example TEST_RUNNER_SNAPSHOT_TESTING_RECORD which causes the library to record. This allows the user to run tests and catch regressions locally before pushing via the Pointfree library's own diff algo and on CI it will just be used to export images. It's also worth noting enabling recording causes XCTest failures which we ignore on CI but will run as real regression tests locally.

NicoHinderling · 2026-04-16T16:58:56Z

+      #       COMPILATION_CACHING=YES \
+      #       EAGER_LINKING=YES \
+      #       FUSE_BUILD_SCRIPT_PHASES=YES \
+      #       | xcpretty


I think lets actually uncomment and keep this in here! I think it's a great example :)

@NicoHinderling There is actually one issue at the moment the filenames don't include the simulator device info or runtime so iPad images would overwrite the iOS ones. What do we think the best strategy is for users on this?

Should we use nested folders does that name space on Sentry?

Should we just rename the files adding a prefix or suffix post generation?

Should the library automatically name images based on device/runtime?

Some things that are not clear to me is how we disambiguate on the Sentry end and what the expected exp. is for multiple platform/device snapshots.

getsentry/sentry-cli#3269

i actually just merged a PR related to this yesterday to add proper subdirectory support within the snapshots images-to-upload folder...

so I think two things:

In our example, we should upload the ipad and iphone images as nested subdirectories, that way the image_file_name value will be unique for all images

the deviceType is exactly the kind of metadata that the snapshotPreviews library should expose that we can then pass into the JSON sidecar metadata thanks to your PR :)

As a reminder, the setup currently allows you to include whatever extra fields you want in the metadata upload, so could you make sure for this example we include declaredDevice/simulatorDeviceName in this upload?

Upstream SnapshotPreviews CI-export changes have merged to main, so the temporary cameroncooke/snapshot-ci branch pin is no longer needed. Reverts both project.pbxproj and Package.resolved to match main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

sentry · 2026-04-16T17:41:34Z

+          restore-keys: ${{ runner.os }}-spm-
+
+      - name: Generate snapshot images
+        continue-on-error: true


Bug: The snapshot generation workflow uses an unrecognized environment variable TEST_RUNNER_SNAPSHOT_TESTING_RECORD, causing tests to fail silently due to continue-on-error: true without generating any snapshots.
_{Severity: HIGH}

Suggested Fix

Either pass the environment variable without the TEST_RUNNER_ prefix directly to the xcodebuild command, or add code within the test target to read the prefixed variable from ProcessInfo.processInfo.environment and configure the snapshot testing library accordingly.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: .github/workflows/ios_sentry_upload_swift_snapshots.yml#L51 Potential issue: The CI workflow `ios_sentry_upload_swift_snapshots.yml` is configured to generate snapshot tests by setting the `TEST_RUNNER_SNAPSHOT_TESTING_RECORD` environment variable. However, the `swift-snapshot-testing` library does not recognize this variable; it expects `SNAPSHOT_TESTING_RECORD`. Concurrently, the code that previously enabled recording, `withSnapshotTesting(record: .all)`, has been removed. As a result, the tests will not enter recording mode and will fail because no reference snapshots exist. This failure is masked by `continue-on-error: true` in the workflow, causing the job to proceed silently without generating or uploading any snapshots, despite appearing to succeed.

This is in fact correct, SNAPSHOT_TESTING_RECORD is used by PointFree's SwiftSnashotTesting library to force snapshot recording. The TEST_RUNNER_ prefix is a way to pass environmental variables to the test runner. xcodebuild will remove the prefix before making the environmental variable available to the test runner process. See: https://developer.apple.com/documentation/xcode/environment-variable-reference

sentry bot reviewed Apr 1, 2026

View reviewed changes

Comment thread .github/scripts/ios/emerge-snapshots Outdated

cameroncooke mentioned this pull request Apr 1, 2026

feat(snapshots): Add CI image export via SNAPSHOTS_EXPORT_DIR env var (EME-931) EmergeTools/SnapshotPreviews#252

Merged

sentry bot reviewed Apr 3, 2026

View reviewed changes

Comment thread .github/scripts/ios/emerge-snapshots Outdated

cameroncooke force-pushed the cameroncooke/snapshots-ci branch 3 times, most recently from 7502a1a to beb2055 Compare April 7, 2026 09:59

sentry bot reviewed Apr 7, 2026

View reviewed changes

Comment thread .github/workflows/ios_sentry_upload_snapshots.yml Outdated

Comment thread .github/workflows/ios_sentry_upload_snapshots.yml

Comment thread ios/HackerNews.xcodeproj/xcshareddata/xcschemes/HackerNews.xcscheme Outdated

cameroncooke and others added 5 commits April 7, 2026 12:11

Use SnapshotPreviews from cameroncooke/snapshot-ci branch

c2b918e

Upload workflow to support new SnapshotPreviews image exports

56fdd63

Update package reference

676b945

cameroncooke force-pushed the cameroncooke/snapshots-ci branch from 537b41f to 4b99f38 Compare April 7, 2026 11:11

ci(ios): Add pull_request trigger to snapshot upload workflow

5f81e4c

Run the snapshot upload workflow on PRs targeting main in addition to pushes, scoped to ios and workflow file paths for both triggers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

sentry bot reviewed Apr 7, 2026

View reviewed changes

Comment thread .github/workflows/ios_sentry_upload_snapshots.yml

cameroncooke and others added 2 commits April 7, 2026 12:33

Disable iPad run

1c63516

sentry bot reviewed Apr 7, 2026

View reviewed changes

Comment thread ios/HackerNews.xcodeproj/project.pbxproj Outdated

cameroncooke and others added 2 commits April 7, 2026 14:43

sentry bot reviewed Apr 7, 2026

View reviewed changes

Comment thread .github/workflows/ios_sentry_upload_snapshots.yml

cameroncooke and others added 4 commits April 8, 2026 09:42

ci: trigger snapshot workflow to test warm cache

4693c5c

Update to use latest SnapshotPreviews branch commit

887a063

sentry bot reviewed Apr 8, 2026

View reviewed changes

Comment thread .github/workflows/ios_sentry_upload_snapshots.yml

cameroncooke and others added 2 commits April 8, 2026 11:52

cameroncooke and others added 2 commits April 8, 2026 14:51

NicoHinderling reviewed Apr 16, 2026

View reviewed changes

Comment thread ios/HackerNews.xcodeproj/project.pbxproj Outdated

NicoHinderling reviewed Apr 16, 2026

View reviewed changes

Comment thread ios/HackerNews.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Outdated

NicoHinderling reviewed Apr 16, 2026

View reviewed changes

sentry bot reviewed Apr 16, 2026

View reviewed changes

NicoHinderling changed the title ~~[do not merge] Use SnapshotPreviews from Cameroncooke/snapshots ci branch~~ Use SnapshotPreviews from Cameroncooke/snapshots ci branch Apr 16, 2026

Conversation

cameroncooke commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

emerge-tools bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📸 Snapshot Test

1 modified, 71 unchanged

Uh oh!

sentry bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

iOS

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentry bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sentry Snapshot Testing

Uh oh!

Uh oh!

NicoHinderling Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

cameroncooke Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NicoHinderling Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

cameroncooke Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

NicoHinderling Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

sentry bot Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

cameroncooke Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cameroncooke commented Apr 1, 2026 •

edited

Loading

emerge-tools bot commented Apr 3, 2026 •

edited

Loading

sentry bot commented Apr 3, 2026 •

edited

Loading

sentry bot commented Apr 15, 2026 •

edited

Loading

cameroncooke Apr 16, 2026 •

edited

Loading

cameroncooke Apr 16, 2026 •

edited

Loading