refactor: 💡 updated target ui to render all targets#118
Open
ulsting wants to merge 1 commit intoEndebert:devfrom
Open
refactor: 💡 updated target ui to render all targets#118ulsting wants to merge 1 commit intoEndebert:devfrom
ulsting wants to merge 1 commit intoEndebert:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Closes: #45
Modified the UI to show all targets for a line or area attack at the same time. Attached are screenshots of the UI changes in desktop and mobile. I modified the footer to have
maxHeight: 20vhso if there are a lot of targets it will render as many as it can and the rest can be seen by scrolling on the y axis.Desktop Screenshot:
Mobile Screenshot:
@Endebert I used the
refactorkeyword for this commit but I'm happy to modify the commit message tofeatin order to bump the version if you want.