Move funder acknowledgements from CITATION.cff to README.md#1253
Merged
Move funder acknowledgements from CITATION.cff to README.md#1253
CITATION.cff to README.md#1253Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates project metadata/documentation so funding acknowledgements live in the README (not the citation metadata), and avoids duplicating the “Overview” text between the repository README and the mdBook docs landing page.
Changes:
- Removed funder acknowledgement text from
CITATION.cff’smessagefield, keeping it focused on citation guidance. - Added funder acknowledgement (with a grant link) to the “Overview” section in
README.md. - Replaced duplicated overview prose in
docs/README.mdwith an mdBook{{#include ...}}of the anchored “Overview” section fromREADME.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docs/README.md |
Uses mdBook include to pull the shared Overview text from the repo README.md. |
README.md |
Adds an anchored Overview block and moves funder acknowledgements here (with a grant link). |
CITATION.cff |
Removes funding acknowledgement from the citation message and simplifies the message text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 57 57
Lines 8195 8195
Branches 8195 8195
=======================================
Hits 7355 7355
Misses 544 544
Partials 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsmbland
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I used the
CITATION.cfffrom this repo as a template for the one in FROG and @dalonsoa pointed out a couple of things:README.mdThe logic is that funder acknowledgements aren't really part of the citation and if you include them in the
README.mdyou can also include links to the grant pages. So it's probably a better approach overall. Note that theREADME.mdis included in any source bundle for the release (which you get on Zenodo), so the information is still there.I've changed this repo to use the same convention. The "overview" text is duplicated between
README.mdanddocs/README.md, so while I was at it, I changed things to use mdBook'sincludepre-processor, which removes the need to keep the two in sync.Note that this won't retrospectively affect the entry on Zenodo for the v2.1.0 release (which is fine), but I thought I'd do it now so that I didn't forget for the next release.
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks