Skip to content

fix: Amount fields based on transaction currency #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aravind-Enf merged 1 commit into from
Feb 13, 2026
Merged

fix: Amount fields based on transaction currency #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion payment_advice/payment_advice/doctype/payment_advice/payment_advice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ function toggle_exchange_rate_field(frm) {

function convert_amount(frm) {

if (!frm.doc.amount) return;
// if (!frm.doc.amount) return;

let total = 0;
if (
Expand Down
5 changes: 4 additions & 1 deletion payment_advice/payment_advice/doctype/payment_advice/payment_advice.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,12 +335,14 @@
"fieldname": "amount_in_trans_cur",
"fieldtype": "Currency",
"label": "Total Amount",
"options": "transaction_currency",
"read_only": 1
},
{
"fieldname": "amount_paid_in_trans_curr",
"fieldtype": "Currency",
"label": "Total Amount Paid",
"options": "transaction_currency",
"read_only": 1
},
{
Expand All @@ -353,6 +355,7 @@
"fieldname": "amount_to_be_settled_trans_curr",
"fieldtype": "Currency",
"label": "Total Amount To be Settled",
"options": "transaction_currency",
"read_only": 1
}
],
Expand All @@ -364,7 +367,7 @@
"link_fieldname": "custom_payment_advice"
}
],
"modified": "2026-02-12 18:23:42.737425",
"modified": "2026-02-13 12:24:52.258169",
"modified_by": "Administrator",
"module": "Payment Advice",
"name": "Payment Advice",
Expand Down
2 changes: 2 additions & 0 deletions payment_advice/payment_advice/doctype/payment_advice/payment_advice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ class PaymentAdvice(Document):
def validate(self):
if self.amount_to_be_settled:
self.amount_to_be_settled_in_words = money_in_words(self.amount_to_be_settled)
if self.amount_to_be_settled_trans_curr:
self.amount_words_trans_curr = money_in_words(self.amount_to_be_settled_trans_curr, self.transaction_currency)
if self.payment_amount:
pending = self.amount_to_be_settled - self.payment_amount
self.pending_amount = pending if pending > 0 else 0
Expand Down
5 changes: 4 additions & 1 deletion payment_advice/payment_advice/doctype/payment_advice_reference/payment_advice_reference.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,21 @@
"fieldname": "amount_in_currency",
"fieldtype": "Currency",
"label": "Total Amount in Currency",
"options": "currency",
"read_only": 1
},
{
"fieldname": "settled_amount_in_currency",
"fieldtype": "Currency",
"label": "Settled Amount in Currency",
"options": "currency",
"read_only": 1
},
{
"fieldname": "net_payable_amount_in_currency",
"fieldtype": "Currency",
"label": "Net Payable Amount in Currency",
"options": "currency",
"read_only": 1
},
{
Expand All @@ -143,7 +146,7 @@
"index_web_pages_for_search": 1,
"istable": 1,
"links": [],
"modified": "2026-02-12 19:20:45.177581",
"modified": "2026-02-13 12:28:17.239483",
"modified_by": "Administrator",
"module": "Payment Advice",
"name": "Payment Advice Reference",
Expand Down
Loading