-
Notifications
You must be signed in to change notification settings - Fork 6
chore: consolidate open Dependabot PRs #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
75e9c7d
019d67a
a041f78
88d4394
915b2a4
27f1087
e647a8d
9041967
ad9ed09
bdef323
ec56021
dd171af
2af53fb
e0c67a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -7,6 +7,12 @@ | |||||||||
| ############################################################################################################################# | ||||||||||
| name: $(version_major).$(version_minor).$(version_patch)-$(Build.SourceBranchName)-$(Rev:r) | ||||||||||
|
|
||||||||||
| parameters: | ||||||||||
| - name: runVulnerabilityScan | ||||||||||
| displayName: Run OWASP Dependency Check | ||||||||||
| type: boolean | ||||||||||
| default: false | ||||||||||
|
||||||||||
| default: false | |
| default: true |
Copilot
AI
Mar 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the pipeline to disable OWASP Dependency Check by default (runVulnerabilityScan defaults to false, and vulnerability_scan now comes from that parameter). This is a security regression compared to the previous always-on scan; consider defaulting the parameter to true (and optionally allow overriding to false) or restricting disabling to non-protected branches so scheduled/mainline builds still always run the scan.
| default: false | |
| default: true |
Copilot
AI
Mar 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vulnerability_scan is now sourced from a boolean parameter, but later this file passes it into templates as a quoted value. The templates gate steps with if eq(parameters.vulnerability_scan, true), which won’t evaluate as expected if the parameter arrives as a string. Pass booleans through without quotes (or change template conditions to compare against a string) so toggling this parameter actually enables/disables the scan.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,30 +15,32 @@ | |
| import java.util.UUID; | ||
| import org.junit.jupiter.api.Tag; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.boot.test.context.SpringBootTest; | ||
| import org.springframework.test.util.ReflectionTestUtils; | ||
|
|
||
| @Tag("Unit") | ||
| @SpringBootTest( | ||
| classes = { | ||
| MenuMapper.class, | ||
| MenuMapperImpl.class, | ||
| CategoryMapper.class, | ||
| CategoryMapperImpl.class, | ||
| ItemMapper.class, | ||
| ItemMapperImpl.class, | ||
| SearchMenuResultItemMapper.class, | ||
| SearchMenuResultItemMapperImpl.class | ||
| }) | ||
| class DomainToDtoMapperMapstructTest { | ||
|
|
||
| @Autowired private MenuMapper menuMapper; | ||
| private final MenuMapper menuMapper; | ||
|
|
||
| @Autowired private CategoryMapper categoryMapper; | ||
| private final CategoryMapper categoryMapper; | ||
|
|
||
| @Autowired private ItemMapper itemMapper; | ||
| private final ItemMapper itemMapper; | ||
|
|
||
| @Autowired private SearchMenuResultItemMapper searchMenuResultItemMapper; | ||
| private final SearchMenuResultItemMapper searchMenuResultItemMapper; | ||
|
|
||
| DomainToDtoMapperMapstructTest() { | ||
| itemMapper = new ItemMapperImpl(); | ||
|
|
||
| CategoryMapperImpl categoryMapperImpl = new CategoryMapperImpl(); | ||
| ReflectionTestUtils.setField(categoryMapperImpl, "itemMapper", itemMapper); | ||
| categoryMapper = categoryMapperImpl; | ||
|
|
||
| MenuMapperImpl menuMapperImpl = new MenuMapperImpl(); | ||
| ReflectionTestUtils.setField(menuMapperImpl, "categoryMapper", categoryMapper); | ||
| menuMapper = menuMapperImpl; | ||
|
Comment on lines
+31
to
+40
|
||
|
|
||
| searchMenuResultItemMapper = new SearchMenuResultItemMapperImpl(); | ||
| } | ||
|
|
||
| @Test | ||
| void menuToMenuDto() { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| spring: | ||
| cloud: | ||
| compatibility-verifier: | ||
| enabled: false | ||
| config: | ||
| enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jackson-core/jackson-databind are set to 2.21.1, but jackson-annotations is pinned separately to 2.21. This introduces mixed Jackson patch versions, which can cause dependency convergence issues and makes it harder to reason about CVE coverage. Consider aligning jackson-annotations to the same version as the other Jackson artifacts (or manage them via a single BOM/version property).