fix(pi-cli): use inverted provider env mapping for future-proof isolation#784
Merged
fix(pi-cli): use inverted provider env mapping for future-proof isolation#784
Conversation
…tion Instead of hardcoding which env vars to strip per provider, define which env vars each provider owns and strip all others. Adding a new provider only requires one map entry instead of updating every existing entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
792a873
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f3cc4e45.agentv.pages.dev |
| Branch Preview URL: | https://fix-pi-cli-env-mapping.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before/After
Before: Hardcoded per-provider removal lists — if
subprovider: mistralwas configured, no vars would be stripped (provider not in map), and Azure could still hijack the session.After: Unknown providers still get all known competing vars stripped. New providers just need one entry in
PROVIDER_OWN_PREFIXES.Test plan
🤖 Generated with Claude Code