feat(pipeline): agent-mode reliability improvements#793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four issues identified from observing an agent struggle to run evals reliably via the agent-mode pipeline on Windows. All changes are in the
pipelinecommands and the bundledagentv-benchskill.Issues addressed
#789 — Fix Windows subprocess in Python scripts
The bundled scripts (
run_tests.py,run_code_graders.py,bench.py) usedsubprocess.run(["agentv", ...])which fails on Windows becauseagentvresolves to a.ps1wrapper. Changed toshutil.which("agentv")which correctly resolves the executable on all platforms.Also added
.envauto-loading torun_tests.pyso target commands inherit required environment variables (e.g.SEARCH_SERVICE,OPENAI_API_KEY).#790 — Add
--llm-scoresflag topipeline benchpipeline benchpreviously only accepted LLM scores via stdin. In PowerShell, the<operator is reserved, soagentv pipeline bench <dir> < llm_scores.jsonfails with a parse error. Added--llm-scores <path>as an optional flag. Falls back to stdin when omitted (backward compatible).#791 — Add
pipeline runcombined commandAdded
agentv pipeline run <eval> --out <dir>which combines input extraction, CLI target invocation (parallel), and code grading into a single command. Loads.envfrom the eval directory automatically.Before this PR, agent-mode required 4 steps; after, it's 2 commands plus the agent's LLM grading step:
agentv pipeline run evals/my.eval.yaml --out .agentv/results/export/run-1 # ... agent grades responses, writes llm_scores.json ... agentv pipeline bench .agentv/results/export/run-1 --llm-scores llm_scores.json#792 — Update agentv-bench skill docs for cross-platform use
pipeline run→pipeline benchflow--llm-scoresto all bench examplesgradersubagent dispatch isn't availableFiles changed
apps/cli/src/commands/pipeline/run.tspipeline runcommandapps/cli/src/commands/pipeline/bench.ts--llm-scoresflagapps/cli/src/commands/pipeline/index.tsrunsubcommandplugins/agentv-dev/skills/agentv-bench/SKILL.mdplugins/agentv-dev/skills/agentv-bench/scripts/run_tests.pyshutil.which+.envloadingplugins/agentv-dev/skills/agentv-bench/scripts/run_code_graders.pyshutil.whichfixplugins/agentv-dev/skills/agentv-bench/scripts/bench.pyshutil.whichfixCloses #789
Closes #790
Closes #791
Closes #792