fix(pipeline): parallel target invocation and cross-platform category fix#859
Merged
fix(pipeline): parallel target invocation and cross-platform category fix#859
Conversation
execSync blocks the Node.js event loop, so the concurrency pool ran targets sequentially despite the async wrapper. Switch to async exec so workers actually run in parallel. Also adds real-time progress reporting to the invocation step and defaults workers to 5. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
path.sep is \ on Windows, so paths with / were not split correctly, causing all categories to return 'Uncategorized'. Split on both separators to work cross-platform. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying agentv with
|
| Latest commit: |
885c442
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60b67b1a.agentv.pages.dev |
| Branch Preview URL: | https://fix-pipeline-run-parallel-ex.agentv.pages.dev |
pipeline run now respects the workers field from targets.yaml as a fallback when --workers is not passed on the CLI. Precedence: CLI flag > targets.yaml > default (5). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipeline run: replacedexecSyncwith asyncexecso worker concurrency actually works — targets were running one at a time despite the async poolInvoking: X/Y donecounter on stderr, matching the grading step's progress stylederiveCategory: was usingpath.sep(Windows\) to split paths that use/, causing all categories to return "Uncategorized" on Windowspipeline runnow respects theworkersfield from targets.yaml (precedence: CLI flag > targets.yaml > default 5)Test plan
agentv pipeline runand verify targets execute concurrently — 52 targets in 1m36s (vs ~8min sequential)workersfrom targets.yaml is picked up (set to 3, output showed "3 workers")🤖 Generated with Claude Code