Add spec submodule and schema-driven compliance tests#96
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 16, 2026
Merged
Add spec submodule and schema-driven compliance tests#96gvonness-apolitical merged 1 commit intomainfrom
gvonness-apolitical merged 1 commit intomainfrom
Conversation
Pin the codex-file-format-spec repo as a git submodule at spec/ so tests validate against the actual spec schemas rather than hand-written field assertions. - Add jsonschema dev-dependency for Draft 2020-12 validation - New spec_compliance.rs with 35 tests across three modules: mark_schema_validation (10), backward_compatibility (15), example_deserialization (10, 2 ignored for tableCell divergence) - Delete extension_schema.rs (superseded by spec_compliance.rs) - Remove 7 duplicated tests from conformance.rs - Update CI checkout with submodules: true for test jobs - Add weekly spec-check.yml staleness workflow
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex-file-format-specas a git submodule atspec/for single-source-of-truth schema validationspec_compliance.rswith 35 tests across 3 modules:extension_schema.rs(all tests superseded by spec-driven validation)conformance.rs.github/workflows/spec-check.yml)Test plan
cargo test -p cdx-core --test spec_compliance— all 33 non-ignored tests passcargo test -p cdx-core --test conformance— 59 remaining tests passcargo test --workspace --all-features— full suite passes (1060 tests)cargo clippy --workspace --all-features -- -D warnings— no warningssubmodules: truecheckout spec correctly