Align NumberingStyle with spec resetTrigger and style changes#99
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 22, 2026
Merged
Conversation
Update spec submodule to include PR #32 fixes. Replace NumberingStyle.format (String) with style (NumberingStylePattern enum) and reset_per_chapter (bool) with reset_on (ResetTrigger enum) to match the spec's heading-level reset triggers and numbering style patterns. - Add ResetTrigger enum: heading1..heading6, none - Add NumberingStylePattern enum: number, chapter.number, etc. - serde(alias = "format") for backward deserialization compatibility - Update extension-guide.md numbering description
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
00a5532(PR Update rand_core requirement from 0.6 to 0.10 #32 merge commit with 25 spec fixes)NumberingStyle.format: Stringwithstyle: Option<NumberingStylePattern>enum matching spec'snumberingStylevalues (number,chapter.number,section.number,chapter.section.number)NumberingStyle.reset_per_chapter: boolwithreset_on: Option<ResetTrigger>enum matching spec's heading-level reset triggers (heading1..heading6,none)serde(alias = "format")for backward deserialization compatibilityTest plan
cargo buildpassescargo test— 1,060 tests pass (including 33 spec compliance tests)cargo clippy— no new warnings